From patchwork Wed Sep 13 06:04:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 13382467 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4E30EEB596 for ; Wed, 13 Sep 2023 06:04:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=A4WwJwvgQlXVdadZvoSLOaFCQfRHspvf/Ymv8KGYRF0=; b=NONuhH/oh/QhAM 6SqUbWyk7K69PYikUI30+P85m2S5X+BhtoyojhE69XYSkrFsQ6ZcppyXW079hgnbnA2/ndtPYcZu6 EzmlPK+fEGVcSYqjOdyQbqM0WhLFrU2QWo05/G/svKpxYJDiOl5PmtaguRRp/ERUeYrxBYiUqeKQz gP3JmtccJZu4uSYkX2hRxB9QP1wSTbaGAUppcLayDZ/n6mnSjC3oYsqxf0PgTE88B2puQLFsuWXEK hgO7uXsdovQrTQbNjB8DpU3BEGTiqJaYnNaq1VgPwJSY4V9duYz06txlLadxBT1EHSefUeciBU3Nc ZoUgDYs5+Rgabvmk7MjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgIzf-004kAS-1a; Wed, 13 Sep 2023 06:04:55 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qgIzc-004k8L-01 for linux-phy@lists.infradead.org; Wed, 13 Sep 2023 06:04:53 +0000 Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 5E6C380FC; Wed, 13 Sep 2023 06:04:48 +0000 (UTC) From: Tony Lindgren To: Vinod Koul , Kishon Vijay Abraham I , Miaoqian Lin Cc: Ivaylo Dimitrov , Merlijn Wajer , Pavel Machek , Sebastian Reichel , linux-phy@lists.infradead.org Subject: [PATCH v2 1/3] phy: mapphone-mdm6600: Fix runtime disable on probe Date: Wed, 13 Sep 2023 09:04:27 +0300 Message-ID: <20230913060433.48373-1-tony@atomide.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230912_230452_113123_837AEB4D X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Commit d644e0d79829 ("phy: mapphone-mdm6600: Fix PM error handling in phy_mdm6600_probe") caused a regression where we now unconditionally disable runtime PM at the end of the probe while it is only needed on errors. Cc: Ivaylo Dimitrov Cc: Merlijn Wajer Cc: Miaoqian Lin Cc: Pavel Machek Reviewed-by: Sebastian Reichel Fixes: d644e0d79829 ("phy: mapphone-mdm6600: Fix PM error handling in phy_mdm6600_probe") Signed-off-by: Tony Lindgren --- Changes since v1: - Added Sebastian's Reviewed-by --- drivers/phy/motorola/phy-mapphone-mdm6600.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c --- a/drivers/phy/motorola/phy-mapphone-mdm6600.c +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c @@ -627,10 +627,12 @@ static int phy_mdm6600_probe(struct platform_device *pdev) pm_runtime_put_autosuspend(ddata->dev); cleanup: - if (error < 0) + if (error < 0) { phy_mdm6600_device_power_off(ddata); - pm_runtime_disable(ddata->dev); - pm_runtime_dont_use_autosuspend(ddata->dev); + pm_runtime_disable(ddata->dev); + pm_runtime_dont_use_autosuspend(ddata->dev); + } + return error; }