| Message ID | 20231122-phy-qualcomm-eusb2-x1e80100-v1-1-ce0991161847@linaro.org |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | phy: qcom: snps-eusb2: Add support for X1E80100 | expand |
On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote: > > Add the X1E80100 compatible to the list of supported PHYs. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml > index 8f5d7362046c..ea1809efbf56 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml > @@ -21,6 +21,7 @@ properties: > - qcom,sm8650-snps-eusb2-phy > - const: qcom,sm8550-snps-eusb2-phy Ah, I think this answers my question for patch2. Can we instead reuse the existing compat string as it was done for sm8650? > - const: qcom,sm8550-snps-eusb2-phy > + - const: qcom,x1e80100-snps-eusb2-phy > > reg: > maxItems: 1 > > -- > 2.34.1 > >
On 22/11/2023 12:02, Dmitry Baryshkov wrote: > On Wed, 22 Nov 2023 at 12:28, Abel Vesa <abel.vesa@linaro.org> wrote: >> >> Add the X1E80100 compatible to the list of supported PHYs. >> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> --- >> Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml >> index 8f5d7362046c..ea1809efbf56 100644 >> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml >> @@ -21,6 +21,7 @@ properties: >> - qcom,sm8650-snps-eusb2-phy >> - const: qcom,sm8550-snps-eusb2-phy > > Ah, I think this answers my question for patch2. Can we instead reuse > the existing compat string as it was done for sm8650? If not, commit msg should explain why it cannot. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml index 8f5d7362046c..ea1809efbf56 100644 --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml @@ -21,6 +21,7 @@ properties: - qcom,sm8650-snps-eusb2-phy - const: qcom,sm8550-snps-eusb2-phy - const: qcom,sm8550-snps-eusb2-phy + - const: qcom,x1e80100-snps-eusb2-phy reg: maxItems: 1
Add the X1E80100 compatible to the list of supported PHYs. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> --- Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml | 1 + 1 file changed, 1 insertion(+)