| Message ID | 20240404122559.898930-10-peter.griffin@linaro.org |
|---|---|
| State | Superseded |
| Commit | f2c6d0fa197a1558f4ef50162bb87e6644af232d |
| Headers | show |
| Series | HSI2, UFS & UFS phy support for Tensor GS101 | expand |
On Thu, 2024-04-04 at 13:25 +0100, Peter Griffin wrote: > This allows us to obtain a PMU regmap that is created by the exynos-pmu > driver. Platforms such as gs101 require exynos-pmu created regmap to > issue SMC calls for PMU register accesses. Existing platforms still get > a MMIO regmap as before. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > drivers/phy/samsung/phy-samsung-ufs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c > index 183c88e3d1ec..c567efafc30f 100644 > --- a/drivers/phy/samsung/phy-samsung-ufs.c > +++ b/drivers/phy/samsung/phy-samsung-ufs.c > @@ -18,6 +18,7 @@ > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > #include <linux/regmap.h> > +#include <linux/soc/samsung/exynos-pmu.h> You can now drop the include of linux/mfd/syscon.h Once done, feel free to add Reviewed-by: André Draszik <andre.draszik@linaro.org> > > #include "phy-samsung-ufs.h" > > @@ -255,8 +256,8 @@ static int samsung_ufs_phy_probe(struct platform_device *pdev) > goto out; > } > > - phy->reg_pmu = syscon_regmap_lookup_by_phandle( > - dev->of_node, "samsung,pmu-syscon"); > + phy->reg_pmu = exynos_get_pmu_regmap_by_phandle(dev->of_node, > + "samsung,pmu-syscon"); > if (IS_ERR(phy->reg_pmu)) { > err = PTR_ERR(phy->reg_pmu); > dev_err(dev, "failed syscon remap for pmu\n");
Hi Peter, > -----Original Message----- > From: Peter Griffin <peter.griffin@linaro.org> > Sent: Thursday, April 4, 2024 5:56 PM > To: mturquette@baylibre.com; sboyd@kernel.org; robh@kernel.org; > krzk+dt@kernel.org; conor+dt@kernel.org; vkoul@kernel.org; > kishon@kernel.org; alim.akhtar@samsung.com; avri.altman@wdc.com; > bvanassche@acm.org; s.nawrocki@samsung.com; cw00.choi@samsung.com; > jejb@linux.ibm.com; martin.petersen@oracle.com; > chanho61.park@samsung.com; ebiggers@kernel.org > Cc: linux-scsi@vger.kernel.org; linux-phy@lists.infradead.org; > devicetree@vger.kernel.org; linux-clk@vger.kernel.org; linux-samsung- > soc@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; tudor.ambarus@linaro.org; > andre.draszik@linaro.org; saravanak@google.com; > willmcvicker@google.com; Peter Griffin <peter.griffin@linaro.org> > Subject: [PATCH 09/17] phy: samsung-ufs: use > exynos_get_pmu_regmap_by_phandle() to obtain PMU regmap > > This allows us to obtain a PMU regmap that is created by the exynos-pmu > driver. Platforms such as gs101 require exynos-pmu created regmap to issue > SMC calls for PMU register accesses. Existing platforms still get a MMIO > regmap as before. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- Acked-by: Alim Akhtar <alim.akhtar@samsung.com> > drivers/phy/samsung/phy-samsung-ufs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/samsung/phy-samsung-ufs.c > b/drivers/phy/samsung/phy-samsung-ufs.c > index 183c88e3d1ec..c567efafc30f 100644 > --- a/drivers/phy/samsung/phy-samsung-ufs.c > +++ b/drivers/phy/samsung/phy-samsung-ufs.c > @@ -18,6 +18,7 @@ > #include <linux/phy/phy.h> > #include <linux/platform_device.h> > #include <linux/regmap.h> > +#include <linux/soc/samsung/exynos-pmu.h> > > #include "phy-samsung-ufs.h" > > @@ -255,8 +256,8 @@ static int samsung_ufs_phy_probe(struct > platform_device *pdev) > goto out; > } > > - phy->reg_pmu = syscon_regmap_lookup_by_phandle( > - dev->of_node, "samsung,pmu-syscon"); > + phy->reg_pmu = exynos_get_pmu_regmap_by_phandle(dev- > >of_node, > + "samsung,pmu- > syscon"); > if (IS_ERR(phy->reg_pmu)) { > err = PTR_ERR(phy->reg_pmu); > dev_err(dev, "failed syscon remap for pmu\n"); > -- > 2.44.0.478.gd926399ef9-goog
Hi André, Thanks for the review feedback. On Fri, 5 Apr 2024 at 08:04, André Draszik <andre.draszik@linaro.org> wrote: > > On Thu, 2024-04-04 at 13:25 +0100, Peter Griffin wrote: > > This allows us to obtain a PMU regmap that is created by the exynos-pmu > > driver. Platforms such as gs101 require exynos-pmu created regmap to > > issue SMC calls for PMU register accesses. Existing platforms still get > > a MMIO regmap as before. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > drivers/phy/samsung/phy-samsung-ufs.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c > > index 183c88e3d1ec..c567efafc30f 100644 > > --- a/drivers/phy/samsung/phy-samsung-ufs.c > > +++ b/drivers/phy/samsung/phy-samsung-ufs.c > > @@ -18,6 +18,7 @@ > > #include <linux/phy/phy.h> > > #include <linux/platform_device.h> > > #include <linux/regmap.h> > > +#include <linux/soc/samsung/exynos-pmu.h> > > You can now drop the include of linux/mfd/syscon.h I'll send a followup patch for this. Thanks, Peter
diff --git a/drivers/phy/samsung/phy-samsung-ufs.c b/drivers/phy/samsung/phy-samsung-ufs.c index 183c88e3d1ec..c567efafc30f 100644 --- a/drivers/phy/samsung/phy-samsung-ufs.c +++ b/drivers/phy/samsung/phy-samsung-ufs.c @@ -18,6 +18,7 @@ #include <linux/phy/phy.h> #include <linux/platform_device.h> #include <linux/regmap.h> +#include <linux/soc/samsung/exynos-pmu.h> #include "phy-samsung-ufs.h" @@ -255,8 +256,8 @@ static int samsung_ufs_phy_probe(struct platform_device *pdev) goto out; } - phy->reg_pmu = syscon_regmap_lookup_by_phandle( - dev->of_node, "samsung,pmu-syscon"); + phy->reg_pmu = exynos_get_pmu_regmap_by_phandle(dev->of_node, + "samsung,pmu-syscon"); if (IS_ERR(phy->reg_pmu)) { err = PTR_ERR(phy->reg_pmu); dev_err(dev, "failed syscon remap for pmu\n");
This allows us to obtain a PMU regmap that is created by the exynos-pmu driver. Platforms such as gs101 require exynos-pmu created regmap to issue SMC calls for PMU register accesses. Existing platforms still get a MMIO regmap as before. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- drivers/phy/samsung/phy-samsung-ufs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)