From patchwork Mon Apr 15 17:42:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13630442 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA3B9C4345F for ; Mon, 15 Apr 2024 17:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=HqBY+JG8uymslhhdACDA3l9e/eG44E1bEfA0FCQfYJA=; b=gE5SiuPsbctZDY 6p+mGYumUIWB/yOGlM3L/cvPZYRMmuhQVfj+3zz9wZtdPXrTeE4xIxk50XeMSkWO775/UR/cVqTR1 kwa7ZP5/TsvHpezpibboGFbl0LdGM+PKUEZnRB5X0zR0yHjwwKqRUx0ooGilKL1y8onDOl7saPcPn pOVor52dtDYcWEICSeyeP/2qV33ngTUuBDxyWejq46gNVowu8YO5Jt+n8Y0A8xfcgNPfAMjH/JXJA FZlamxljOCkTcPZ6UuojSqNsq/mtHpbN2kxm5K5Cyc4v+AFx1MLPxuq1nh8SRa1xc2l4rs/nHTBfT Na6Old8XRB4rYVCxlSsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwQM6-00000009Mh3-2Ffx; Mon, 15 Apr 2024 17:42:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rwQM1-00000009Mg2-3yub; Mon, 15 Apr 2024 17:42:55 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E623260F03; Mon, 15 Apr 2024 17:42:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BF3DC113CC; Mon, 15 Apr 2024 17:42:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713202972; bh=b5rLA/xVoC+OnWb0hZtV4A0foD6WE7RauuxZaOV01Mg=; h=From:To:Cc:Subject:Date:From; b=joHMUDe3XpppSRRtQPD1MK47Dqe0DuaSAuEkdvdS+QkgldwdLCa7GWZDYld4zOc/Y C2f+RzkS/7WbglclkVG8xy+L7ipbFF9aMiA5h7WFmvr4DGgd6Z4B+jQ32DdZyikgne Vs6x6Vv1rmX/e+kuXHXsbzubN7QbEGyiFshsw+itXPA3YlTpgV1eWUjEZ8e6RHzebY 8FRyTXPj59ZpchT5O80bda4/9uuW48nKKb8JWauEYZ563mYJdrhlXRoM78OCTxh+gD BAGbhjrJBcLe9ggXi9ci+h81/p35HDlrP91bBncIFPxWWpfsVvVSbvLY/kIsCp34KJ /rdxZyjpKbD+Q== From: Arnd Bergmann To: Vinod Koul , Kishon Vijay Abraham I Cc: Arnd Bergmann , Heiko Stuebner , Cristian Ciocaltea , Zhang Yubing , Frank Wang , Sebastian Reichel , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] phy: rockchip: fix CONFIG_TYPEC dependency Date: Mon, 15 Apr 2024 19:42:25 +0200 Message-Id: <20240415174241.77982-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240415_104254_231165_08F14ED2 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann The newly added driver causes a warning about missing dependencies by selecting CONFIG_TYPEC unconditionally: WARNING: unmet direct dependencies detected for TYPEC Depends on [n]: USB_SUPPORT [=n] Selected by [y]: - PHY_ROCKCHIP_USBDP [=y] && ARCH_ROCKCHIP [=y] && OF [=y] WARNING: unmet direct dependencies detected for USB_COMMON Depends on [n]: USB_SUPPORT [=n] Selected by [y]: - EXTCON_RTK_TYPE_C [=y] && EXTCON [=y] && (ARCH_REALTEK [=y] || COMPILE_TEST [=y]) && TYPEC [=y] Since that is a user-visible option, it should not really be selected in the first place. Replace the 'select' with a 'depends on' as we have for similar drivers. Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") Signed-off-by: Arnd Bergmann Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index a752ccdddb86..08b0f4345760 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -120,8 +120,8 @@ config PHY_ROCKCHIP_USB config PHY_ROCKCHIP_USBDP tristate "Rockchip USBDP COMBO PHY Driver" depends on ARCH_ROCKCHIP && OF + depends on TYPEC select GENERIC_PHY - select TYPEC help Enable this to support the Rockchip USB3.0/DP combo PHY with Samsung IP block. This is required for USB3 support on RK3588.