| Message ID | 20241026132014.73050-1-aford173@gmail.com |
|---|---|
| State | Accepted |
| Commit | 2a9868d69be26e623dd0bf4231d5175f0ccf5d6f |
| Headers | show |
| Series | [V2,1/3] phy: freescale: fsl-samsung-hdmi: Expand Integer divider range | expand |
On Sat, Oct 26, 2024 at 8:20 AM Adam Ford <aford173@gmail.com> wrote: > > The Integer divder uses values of P,M, and S to determine the PLL > rate. Currently, the range of M was set based on a series of > table entries where the range was limited. Since the ref manual > shows it is 8-bit wide, expand the range to be up to 255. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> > --- > V2: Fix typo in comment Vinod, Is there any chance this series could also be applied for the next release? I don't know what the cutoff deadline is, so if I'm too late, I apologize. adam > > diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > index 2c8038864357..412c03b7dcd6 100644 > --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > @@ -406,16 +406,15 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1 > continue; > > /* > - * TODO: Ref Manual doesn't state the range of _m > - * so this should be further refined if possible. > - * This range was set based on the original values > - * in the lookup table > + * The Ref manual doesn't explicitly state the range of M, > + * but it does show it as an 8-bit value, so reject > + * any value above 255. > */ > tmp = (u64)fout * (_p * _s); > do_div(tmp, 24 * MHZ); > - _m = tmp; > - if (_m < 0x30 || _m > 0x7b) > + if (tmp > 255) > continue; > + _m = tmp; > > /* > * Rev 2 of the Ref Manual states the > -- > 2.45.2 >
On Sat, Oct 26, 2024 at 8:20 AM Adam Ford <aford173@gmail.com> wrote: > > The Integer divder uses values of P,M, and S to determine the PLL > rate. Currently, the range of M was set based on a series of > table entries where the range was limited. Since the ref manual > shows it is 8-bit wide, expand the range to be up to 255. > > Signed-off-by: Adam Ford <aford173@gmail.com> > Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de> Vinod, Do you have any feedback on this series? RC1 is available, and it would be nice to see this series merged soon unless you have changes you want implemented. Thank you, adam > --- > V2: Fix typo in comment > > diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > index 2c8038864357..412c03b7dcd6 100644 > --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c > @@ -406,16 +406,15 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1 > continue; > > /* > - * TODO: Ref Manual doesn't state the range of _m > - * so this should be further refined if possible. > - * This range was set based on the original values > - * in the lookup table > + * The Ref manual doesn't explicitly state the range of M, > + * but it does show it as an 8-bit value, so reject > + * any value above 255. > */ > tmp = (u64)fout * (_p * _s); > do_div(tmp, 24 * MHZ); > - _m = tmp; > - if (_m < 0x30 || _m > 0x7b) > + if (tmp > 255) > continue; > + _m = tmp; > > /* > * Rev 2 of the Ref Manual states the > -- > 2.45.2 >
On Sat, 26 Oct 2024 08:19:57 -0500, Adam Ford wrote: > The Integer divder uses values of P,M, and S to determine the PLL > rate. Currently, the range of M was set based on a series of > table entries where the range was limited. Since the ref manual > shows it is 8-bit wide, expand the range to be up to 255. > > Applied, thanks! [1/3] phy: freescale: fsl-samsung-hdmi: Expand Integer divider range commit: 2a9868d69be26e623dd0bf4231d5175f0ccf5d6f [2/3] phy: freescale: fsl-samsung-hdmi: Stop searching when exact match is found commit: 1b9b8b159601d174526ce1c3a62ebe3a7286003b [3/3] phy: freescale: fsl-samsung-hdmi: Clean up fld_tg_code calculation commit: d567679f2b6a8bcea20589bbea6488c0236886cd Best regards,
diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c index 2c8038864357..412c03b7dcd6 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -406,16 +406,15 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1 continue; /* - * TODO: Ref Manual doesn't state the range of _m - * so this should be further refined if possible. - * This range was set based on the original values - * in the lookup table + * The Ref manual doesn't explicitly state the range of M, + * but it does show it as an 8-bit value, so reject + * any value above 255. */ tmp = (u64)fout * (_p * _s); do_div(tmp, 24 * MHZ); - _m = tmp; - if (_m < 0x30 || _m > 0x7b) + if (tmp > 255) continue; + _m = tmp; /* * Rev 2 of the Ref Manual states the