| Message ID | 20250109032725.1102465-14-damon.ding@rock-chips.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add eDP support for RK3588 | expand |
On Thu, Jan 09, 2025 at 11:27:18AM +0800, Damon Ding wrote: > Compared with RK3288/RK3399, the HBR2 link rate support is the main > improvement of RK3588 eDP TX controller, and there are also two > independent eDP display interfaces on RK3588 Soc. > > The newly added 'apb' reset is to ensure the APB bus of eDP controller > works well on the RK3588 SoC. > > Signed-off-by: Damon Ding <damon.ding@rock-chips.com> > > --- > > Changes in v2: > - Add the main defferences of the RK3588 eDP and the previous versions > in commit message > > Changes in v3: > - Expand the property clock-names, resets and reset-names > > Changes in v4: > - Remove 'spdif' clock which added in v3 > - Add the comment of newly added 'apb' reset in commit message > > Changes in v5: > - Put the differences between RK3288/RK3399 and RK3588 into 'allOf' > --- > .../rockchip/rockchip,analogix-dp.yaml | 37 ++++++++++++++++--- > 1 file changed, 31 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml > index eaf4e67e232e..3cdea9e63522 100644 > --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml > @@ -15,6 +15,7 @@ properties: > enum: > - rockchip,rk3288-dp > - rockchip,rk3399-edp > + - rockchip,rk3588-edp > > clocks: > minItems: 2 > @@ -30,12 +31,6 @@ properties: > power-domains: > maxItems: 1 > > - resets: > - maxItems: 1 > - > - reset-names: > - const: dp Widest constraints are always here. You only needed to add allOf. https://elixir.bootlin.com/linux/v6.11-rc6/source/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml index eaf4e67e232e..3cdea9e63522 100644 --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml @@ -15,6 +15,7 @@ properties: enum: - rockchip,rk3288-dp - rockchip,rk3399-edp + - rockchip,rk3588-edp clocks: minItems: 2 @@ -30,12 +31,6 @@ properties: power-domains: maxItems: 1 - resets: - maxItems: 1 - - reset-names: - const: dp - rockchip,grf: $ref: /schemas/types.yaml#/definitions/phandle description: @@ -55,6 +50,36 @@ required: allOf: - $ref: /schemas/display/bridge/analogix,dp.yaml# + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3288-dp + - rockchip,rk3399-edp + then: + properties: + resets: + maxItems: 1 + reset-names: + const: dp + + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3588-edp + then: + properties: + resets: + minItems: 2 + maxItems: 2 + reset-names: + items: + - const: dp + - const: apb + unevaluatedProperties: false examples:
Compared with RK3288/RK3399, the HBR2 link rate support is the main improvement of RK3588 eDP TX controller, and there are also two independent eDP display interfaces on RK3588 Soc. The newly added 'apb' reset is to ensure the APB bus of eDP controller works well on the RK3588 SoC. Signed-off-by: Damon Ding <damon.ding@rock-chips.com> --- Changes in v2: - Add the main defferences of the RK3588 eDP and the previous versions in commit message Changes in v3: - Expand the property clock-names, resets and reset-names Changes in v4: - Remove 'spdif' clock which added in v3 - Add the comment of newly added 'apb' reset in commit message Changes in v5: - Put the differences between RK3288/RK3399 and RK3588 into 'allOf' --- .../rockchip/rockchip,analogix-dp.yaml | 37 ++++++++++++++++--- 1 file changed, 31 insertions(+), 6 deletions(-)