From patchwork Thu Feb 27 07:05:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13993815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26D7DC19F2E for ; Thu, 27 Feb 2025 07:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=NSdUhSUqgbDhuyQK98x8WXEl9BO0ZfDagvTAEc3V1Cc=; b=FFghVadSdv1KE3 uard5qBE4dA4j5Gw9x+EkNJHkPVnxQxDbKirechMrdX88rbkUnOMke+oiETRKUCFaTt97+FKFukgG cF1Cw0jDK2dOxjSYvGa3d7lS4jDBjeRhEYB/cjDJxvs+3fRG+6uPFMffbcyA7aHgGu0rnwY4DcbuH akN3pgu/owWZ1F5P2X7Re78Cpmv35pSfCgBjrSQbPlwFg3AVGsih9n5mHUntG3Rt8vHzRNNijBNFV KjH0iDA8QInU9k4kTwxSQkTGB8+BmURt346CnCkBPPm7vn1n9JXEL6rcP8Ll1mrbCIn97+B9Q0Q50 exfEknlYJCAmy96gzGGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnXyo-00000006WcB-3JvK; Thu, 27 Feb 2025 07:06:46 +0000 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnXxT-00000006WOy-0qz1 for linux-phy@lists.infradead.org; Thu, 27 Feb 2025 07:05:24 +0000 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-ab7098af6fdso7797366b.2 for ; Wed, 26 Feb 2025 23:05:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740639922; x=1741244722; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0apQcE6PfzPMLUzCFy/8QBbVfjes8kdxgXVKnN/YLIM=; b=KtJfcZEgLuj7F9wT/3sviJiHJzJIaD1TUUGtaKa8bGTq45HtIM0xixxZl5LO93/JX9 di4RlzwJItgDT1jyW0ojDEo3OdVAm7/KNii8/MFs6fgvdJSNAo+vWUb3jmkeUTZTKI+s EvxiFRek+h7V1yxFfj75AGsfSNuj9kRP3X8E1MJ0fY4bu01fWHwlx+4VvdvzWRkM856/ f7Zyl/R0Mj9wXCD3AEjJphMv2AQpD8Y4hutqhou2uOu6nO3pTdZUwG6YrDYMkFqOgsh6 WNmG4ud3c9OzPw2whocDsjdCKfpLGkBNZxrdkoU3TVB6ctmmuNircPjQwbAhVH0FYPDD KJYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740639922; x=1741244722; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0apQcE6PfzPMLUzCFy/8QBbVfjes8kdxgXVKnN/YLIM=; b=U1XtZB7KnyjXEr/hlURh5id5z0LwMtksoph7JtILIb1ytgHGwCLBvDfWCRNLOfaCug oOSkPZBIDfSJX82ieTTW7p/CkoOwg0h59oqjYUBpIqoMxfzOnOLDMyT4jKBaosS3zlad DMdOwL7qVCpHexvNugfBfa68dqRoO2quXDqOYgsddrC/88OfwWzX8rV7y1Mfvh6m85Lp urGLQ/d9eOsCMF38RprmsjP5nrfldIOGa69h+RxaZgvBIgNvYz6jQSKxTYe5XYYt45EQ 5dj5TR6srOQUPO/bXPXW0Aka/0xW+J+h3nATUD+w45FOpLJKY2Qa01LrQbJ4vlrwJnJV N4aA== X-Forwarded-Encrypted: i=1; AJvYcCWNBDoiYEYCC9qOLQnWZeD4yH3U1dSvMcc+sAqkYfA46joikochUkwYOmf+fq62GOhjqbv5qXNWCXo=@lists.infradead.org X-Gm-Message-State: AOJu0YxQIalYWt9tawVt8hxsnb1CqUPQ45RZq2FDIwcVgh351fZtE6Is JFaFaUyEcPYezHfRNmYYH2IbJTq3rDfVqwBy+S29OmoAs0DahCOQK5Fq+tGx86Y= X-Gm-Gg: ASbGncsowtc+jEOCXTWUhDrYWOCXZzqlZ+FuBSHfbnCgxbiR1+KldUK2Ve8dzXL2HGO 1sacV5AcnBcCSG17f8NI3maHtVVAUeoL5sGeSlmqor95/2JMmrAE2k6LjwpwnkehrVcwpjMHcQ6 t/koZN7DZ4QeXO+uAWZeiSeq148L2ExjZIKZT0oFykFJqC759O18pmnCZaCMfhxk4/WS4ErN0zK EzwWknbwqcguczuTEHMk6tVninu0dtz60gP/fpvrSmupdPHik2gH/k3hX9TgozgYDUhCOCAGwLW vrP8SAHW9/lx8qv+AGEcVRQqkiLhDg+gqa+zx21p X-Google-Smtp-Source: AGHT+IHXy5tCZaZz6X3dSvzvQm4bdYcI3qekmMWxV+GvUxiLx80Fzbswu9wY9k8MAxpjFX7Ux9LlHA== X-Received: by 2002:a17:907:74a:b0:abb:e5ac:28b2 with SMTP id a640c23a62f3a-abc09c24732mr949678066b.13.1740639921638; Wed, 26 Feb 2025 23:05:21 -0800 (PST) Received: from krzk-bin.. ([178.197.206.225]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abf0c6e9c25sm74556466b.108.2025.02.26.23.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2025 23:05:21 -0800 (PST) From: Krzysztof Kozlowski To: Vinod Koul , Kishon Vijay Abraham I , =?utf-8?q?Andr=C3=A9_Draszik?= , Peter Griffin , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Marek Szyprowski Subject: [PATCH v4] phy: exynos5-usbdrd: Do not depend on Type-C Date: Thu, 27 Feb 2025 08:05:18 +0100 Message-ID: <20250227070518.5468-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_230523_325771_3419F74E X-CRM114-Status: GOOD ( 12.15 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Older Exynos designs, like Exynos5422, do not have USB Type-C and the USB DRD PHY does not really need CONFIG_TYPEC for these devices at all. Incorrectly added optional dependency on CONFIG_TYPEC caused this driver to be missing for exynos_defconfig and as result Exynos5422-based boards like Hardkernel Odroid HC1 failed to probe USB. Reported-by: Krzysztof Kozlowski Closes: https://krzk.eu/#/builders/21/builds/6139 Reported-by: Marek Szyprowski Closes: https://lore.kernel.org/all/3c0b77e6-357d-453e-8b63-4757c3231bde@samsung.com/ Fixes: 09dc674295a3 ("phy: exynos5-usbdrd: subscribe to orientation notifier if required") Reviewed-by: André Draszik Tested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- Patch for issue in linux-next Changes in v4: 1. Change subject (Vinod) 2. Add Marek's and Andre's tags. Changes in v3: 1. Simplify and go back to standard optional dependency without intermediate symbol Changes in v2: 1. Add PHY_EXYNOS5_USBDRD_TYPEC, so arm64 defconfig will have both symbols in-sync --- drivers/phy/samsung/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/samsung/Kconfig b/drivers/phy/samsung/Kconfig index 7fba571c0e2b..6566100441d6 100644 --- a/drivers/phy/samsung/Kconfig +++ b/drivers/phy/samsung/Kconfig @@ -81,7 +81,7 @@ config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" depends on (ARCH_EXYNOS && OF) || COMPILE_TEST depends on HAS_IOMEM - depends on TYPEC || (TYPEC=n && COMPILE_TEST) + depends on TYPEC || !TYPEC depends on USB_DWC3_EXYNOS select GENERIC_PHY select MFD_SYSCON