| Message ID | 20250308-phy-sam-hdptx-bpc-v5-2-35087287f9d1@collabora.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: rockchip: samsung-hdptx: Support high color depth management | expand |
On Sat, 8 Mar 2025 at 14:21, Cristian Ciocaltea <cristian.ciocaltea@collabora.com> wrote: > > Extend the HDMI configuration options to allow managing bits per color > channel. This is required by some PHY drivers such as > rockchip-samsung-hdptx. > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > --- > include/linux/phy/phy-hdmi.h | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Just to confirm, are you passing TMDS char rate or pixel clock for DeepColor (bpc > 8) modes?
Hi Dmitry, On 3/9/25 11:16 AM, Dmitry Baryshkov wrote: > On Sat, 8 Mar 2025 at 14:21, Cristian Ciocaltea > <cristian.ciocaltea@collabora.com> wrote: >> >> Extend the HDMI configuration options to allow managing bits per color >> channel. This is required by some PHY drivers such as >> rockchip-samsung-hdptx. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> >> --- >> include/linux/phy/phy-hdmi.h | 2 ++ >> 1 file changed, 2 insertions(+) >> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Just to confirm, are you passing TMDS char rate or pixel clock for > DeepColor (bpc > 8) modes? It's the TMDS char rate, but we still need the bpc info to program CMN_REG(0086) in PATCH 12. Thanks for reviewing, Cristian
On Sun, 9 Mar 2025 at 12:10, Cristian Ciocaltea <cristian.ciocaltea@collabora.com> wrote: > > Hi Dmitry, > > On 3/9/25 11:16 AM, Dmitry Baryshkov wrote: > > On Sat, 8 Mar 2025 at 14:21, Cristian Ciocaltea > > <cristian.ciocaltea@collabora.com> wrote: > >> > >> Extend the HDMI configuration options to allow managing bits per color > >> channel. This is required by some PHY drivers such as > >> rockchip-samsung-hdptx. > >> > >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> > >> --- > >> include/linux/phy/phy-hdmi.h | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Just to confirm, are you passing TMDS char rate or pixel clock for > > DeepColor (bpc > 8) modes? > > It's the TMDS char rate, but we still need the bpc info to program > CMN_REG(0086) in PATCH 12. Thanks for the confirmation.
diff --git a/include/linux/phy/phy-hdmi.h b/include/linux/phy/phy-hdmi.h index 6a696922bc7f29af63d88646701b2c0fcee5c885..f0ec963c6e84f1b7728acafc824dff191c6b873d 100644 --- a/include/linux/phy/phy-hdmi.h +++ b/include/linux/phy/phy-hdmi.h @@ -9,11 +9,13 @@ /** * struct phy_configure_opts_hdmi - HDMI configuration set * @tmds_char_rate: HDMI TMDS Character Rate in Hertz. + * @bpc: Bits per color channel. * * This structure is used to represent the configuration state of a HDMI phy. */ struct phy_configure_opts_hdmi { unsigned long long tmds_char_rate; + unsigned int bpc; }; #endif /* __PHY_HDMI_H_ */
Extend the HDMI configuration options to allow managing bits per color channel. This is required by some PHY drivers such as rockchip-samsung-hdptx. Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- include/linux/phy/phy-hdmi.h | 2 ++ 1 file changed, 2 insertions(+)