| Message ID | 3cc81f2a-efd7-4ef7-ae6b-e38c91efe153@moroto.mountain |
|---|---|
| State | Accepted |
| Commit | 86fe3e9f4c635cf740b31161ee35aed4a78e03f9 |
| Headers | show |
| Series | phy: starfive: fix error code in probe | expand |
On Tue, 18 Jul 2023 10:02:49 +0300, Dan Carpenter wrote: > This is using the wrong pointer, "phy->regs" vs "phy->phy". > > Applied, thanks! [1/1] phy: starfive: fix error code in probe commit: 86fe3e9f4c635cf740b31161ee35aed4a78e03f9 Best regards,
diff --git a/drivers/phy/starfive/phy-jh7110-pcie.c b/drivers/phy/starfive/phy-jh7110-pcie.c index cbe79c1f59d3..734c8e007727 100644 --- a/drivers/phy/starfive/phy-jh7110-pcie.c +++ b/drivers/phy/starfive/phy-jh7110-pcie.c @@ -151,7 +151,7 @@ static int jh7110_pcie_phy_probe(struct platform_device *pdev) phy->phy = devm_phy_create(dev, NULL, &jh7110_pcie_phy_ops); if (IS_ERR(phy->phy)) - return dev_err_probe(dev, PTR_ERR(phy->regs), + return dev_err_probe(dev, PTR_ERR(phy->phy), "Failed to map phy base\n"); phy->sys_syscon =
This is using the wrong pointer, "phy->regs" vs "phy->phy". Fixes: 26cea0e28057 ("phy: starfive: Add JH7110 PCIE 2.0 PHY driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/phy/starfive/phy-jh7110-pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)