From patchwork Fri Mar 8 08:51:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13586563 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A79F2C5475B for ; Fri, 8 Mar 2024 08:52:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=vGkfKbkCXaboYP78X7ySZpsIJ9KWkdRO8voR8g/tNsw=; b=3n5tkOqH/4w13D OwMPtC8XYKPnc9ySr+PZg5kx+TBvgrfh2bM3t0o7Pemur7oqRUDCQuB4NjxuEzPPPmRDJMQIx0zmw aX8D3s2YqyuSYHecsq3ECtZ21+eLYquRqu9FmuuTGbHqymCx8vRLor4607OiBKcW9J5QJQIEx0osg Z/NZVqxonufTqZDNWHBFxJTK0lxoJ4U/bcm36okOFztCEwRMiCr1jQbI29D9tO35Gbfb3q+54+lnE owWpiBirURili2ifP1HFfIBfuEC/HDBAKcB+Z0v9Q0FSneV5ozrp43ta0Evuh0cr2D2YS5tDm/oQ5 sQnVsnI+k82K5DFD3x8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1riVxS-00000008QXP-0dfK; Fri, 08 Mar 2024 08:52:02 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1riVxO-00000008QTo-1ZsG for linux-phy@lists.infradead.org; Fri, 08 Mar 2024 08:52:00 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1riVxG-0006wb-Ea; Fri, 08 Mar 2024 09:51:50 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1riVxG-0056NT-1J; Fri, 08 Mar 2024 09:51:50 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1riVxF-00245s-35; Fri, 08 Mar 2024 09:51:49 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Laurent Pinchart , Vinod Koul , Kishon Vijay Abraham I , Michal Simek Cc: linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH] phy: xilinx: Convert to platform remove callback returning void Date: Fri, 8 Mar 2024 09:51:13 +0100 Message-ID: <57a3338a1cec683ac84d48e00dbf197e15ee5481.1709886922.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1882; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=aVN8+EY/uO3cH4FEyS7VfiUXi1DIt1cu/7mR+1Q406s=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtRXF1si/vb/PSe45SCjRmGIw8xerZNOGfblPP3qfFvys zrFV+7qZDRmYWDkYpAVU2Sxb1yTaVUlF9m59t9lmEGsTCBTGLg4BWAiKc7s/8tcY5vkpm0St7Tb s9f2PWug6qxKa5X7KqK9Zza+OT9d1r+68h9vYWX8cZYTPa+uf2C/fU911ep9+gYXZjHWRimkNJx YevbjwnXL7DN5G1bpM83M7WeLiVFw6v94Q8dP5vZ20eaKsCTt+I3hSgv8zj8z5ZNJuslx2Ydzg3 aguh2PgIrh1snVue4BkxY2nXEq3tGkofxz7c7OkvLjnbKzFfe5n0l+l9j5lKfTWmiutZKMlRrb2 TnZAZsMHp4K6DOTXPHeaPlut/dmK+/7HPojLeMYsTF1tXuzSNTXjSwOp89nNas2v+bZKyi8S1Gs MZLjRvPOpb2MctJPr0wUEVnLdW3O3N/rb/64embNjqJ3AA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-phy@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240308_005158_476742_34B83E51 X-CRM114-Status: GOOD ( 14.96 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Michal Simek --- drivers/phy/xilinx/phy-zynqmp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) base-commit: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c index f72c5257d712..dc8319bda43d 100644 --- a/drivers/phy/xilinx/phy-zynqmp.c +++ b/drivers/phy/xilinx/phy-zynqmp.c @@ -995,15 +995,13 @@ static int xpsgtr_probe(struct platform_device *pdev) return 0; } -static int xpsgtr_remove(struct platform_device *pdev) +static void xpsgtr_remove(struct platform_device *pdev) { struct xpsgtr_dev *gtr_dev = platform_get_drvdata(pdev); pm_runtime_disable(gtr_dev->dev); pm_runtime_put_noidle(gtr_dev->dev); pm_runtime_set_suspended(gtr_dev->dev); - - return 0; } static const struct of_device_id xpsgtr_of_match[] = { @@ -1015,7 +1013,7 @@ MODULE_DEVICE_TABLE(of, xpsgtr_of_match); static struct platform_driver xpsgtr_driver = { .probe = xpsgtr_probe, - .remove = xpsgtr_remove, + .remove_new = xpsgtr_remove, .driver = { .name = "xilinx-psgtr", .of_match_table = xpsgtr_of_match,