From patchwork Mon May 20 10:47:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Saenz Julienne X-Patchwork-Id: 10950857 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C3EE96C5 for ; Mon, 20 May 2019 10:48:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B243D28696 for ; Mon, 20 May 2019 10:48:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A603A28765; Mon, 20 May 2019 10:48:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4B1D228696 for ; Mon, 20 May 2019 10:48:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731950AbfETKrh (ORCPT ); Mon, 20 May 2019 06:47:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:55304 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728000AbfETKrh (ORCPT ); Mon, 20 May 2019 06:47:37 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 88D7AAFD1; Mon, 20 May 2019 10:47:35 +0000 (UTC) From: Nicolas Saenz Julienne To: stefan.wahren@i2se.com, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Cc: mbrugger@suse.de, viresh.kumar@linaro.org, rjw@rjwysocki.net, sboyd@kernel.org, eric@anholt.net, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, ptesarik@suse.com, ssuloev@orpaltech.com, linux-clk@vger.kernel.org, mturquette@baylibre.com, Nicolas Saenz Julienne , linux-kernel@vger.kernel.org Subject: [RFC v2 0/5] cpufreq support for the Raspberry Pi Date: Mon, 20 May 2019 12:47:02 +0200 Message-Id: <20190520104708.11980-1-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi all, as some of you may recall I've been spending some time looking into providing 'cpufreq' support for the Raspberry Pi platform[1]. I think I'm close to something workable, so I'd love for you to comment on it. There has been some design changes since the last version. Namely the fact that I now make sure *only* the CPU frequency is updated. The firmware API we use has two modes, with or without turbo. Enabling turbo implies not only scaling the CPU clock but also the VPU and other peripheral related clocks. This is problematic as some of them are not prepared for this kind frequency changes. I spent some time adapting the peripheral drivers, but the result was disappointing as they poorly support live frequency changes (which most other chips accept, think for instance I2C and clock stretching) but also turned out hard to integrate into the kernel. As we were planning to use 'clk_notifiers' which turns out not to be such a good idea as it's prone to deadlocks and not recommended by the clock maintainers[2]. It's also worth mentioning that the foundation kernel doesn't support VPU frequency scaling either. With this in mind, and as suggested by clock maintainers[2], I've decided to integrate the firmware clock interface into the bcm2835 clock driver. This, in my opinion, provides the least friction with the firmware and lets us write very simple and portable higher level drivers. As I did with the 'cpufreq' driver which simply queries the max and min frequencies available, which are configurable in the firmware, to then trigger the generic 'cpufreq-dt'. In the future we could further integrate other firmware dependent clocks into the main driver. For instance to be able to scale the VPU clock, which should be operated through a 'devfreq' driver. This was tested on a RPi3b+ and if the series is well received I'll test it further on all platforms I own. That's all, kind regards, Nicolas [1] https://lists.infradead.org/pipermail/linux-rpi-kernel/2019-April/008634.html [2] https://www.spinics.net/lists/linux-clk/msg36937.html --- Changes since v1: - Addressed Viresh's comments in cpufreq driver - Resend with (hopefully) proper CCs Nicolas Saenz Julienne (5): clk: bcm2835: set CLK_GET_RATE_NOCACHE on CPU clocks clk: bcm2835: set pllb_arm divisor as readonly clk: bcm2835: use firmware interface to update pllb dts: bcm2837: add per-cpu clock devices cpufreq: add driver for Raspbery Pi arch/arm/boot/dts/bcm2837.dtsi | 8 + drivers/clk/bcm/clk-bcm2835.c | 284 ++++++++++++++++++++++++-- drivers/cpufreq/Kconfig.arm | 8 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/raspberrypi-cpufreq.c | 83 ++++++++ 5 files changed, 366 insertions(+), 18 deletions(-) create mode 100644 drivers/cpufreq/raspberrypi-cpufreq.c