[v4,0/4] X-Powers Power Supply Improvements

Message

Samuel Holland Jan. 15, 2020, 3:40 a.m. UTC

This series adds some improvements to the axp20x_usb_power power supply
driver to better support suspend/resume and use on mobile devices.

Patch 1 is preparation for changes in following patches.
Patch 2 allows userspace to take the power supply offline.
Patch 3 allows userspace to control the wakeup behavior.
Patch 4 avoids polling USB VBUS presence when possible.

Changes since v3:
 - Rebase on power-supply/for-next
 - Add Reviewed-by (1-2)

Changes since v2:
 - Patch 1 was merged
 - Only check ACIN_PATH_SEL when necessary (1)
 - Update commit message (5)
 - Avoided reordering lines until/unless necessary (5, 7)
 - Update comment and add ID check in axp20x_usb_power_set_property
   (it seemed more correct than adding another comment) (6)
 - Add Reviewed-by where there were no comments (2-4, 7-8)

Changes since v1:
 - Add patches 1-2
 - Shift value properly in calls to regmap_update_bits (3, 7)
 - Use #ifdef instead of #if to avoid -Wundef warnings (4, 8)
 - Poll once after an IRQ, instead of setting power->online in the IRQ (9)
 - Poll once on resume, in case the state changed during suspend (9)

Samuel Holland (4):
  power: supply: axp20x_usb_power: Use a match structure
  power: supply: axp20x_usb_power: Allow offlining
  power: supply: axp20x_usb_power: Add wakeup control
  power: supply: axp20x_usb_power: Only poll while offline

 drivers/power/supply/axp20x_usb_power.c | 217 ++++++++++++++++++------
 1 file changed, 169 insertions(+), 48 deletions(-)

Comments

Sebastian Reichel Jan. 15, 2020, 8:48 p.m. UTC | #1

Hi,

Thanks, all queued to power-supply's for-next branch.

-- Sebastian

On Tue, Jan 14, 2020 at 09:40:44PM -0600, Samuel Holland wrote:
> This series adds some improvements to the axp20x_usb_power power supply
> driver to better support suspend/resume and use on mobile devices.
> 
> Patch 1 is preparation for changes in following patches.
> Patch 2 allows userspace to take the power supply offline.
> Patch 3 allows userspace to control the wakeup behavior.
> Patch 4 avoids polling USB VBUS presence when possible.
> 
> Changes since v3:
>  - Rebase on power-supply/for-next
>  - Add Reviewed-by (1-2)
> 
> Changes since v2:
>  - Patch 1 was merged
>  - Only check ACIN_PATH_SEL when necessary (1)
>  - Update commit message (5)
>  - Avoided reordering lines until/unless necessary (5, 7)
>  - Update comment and add ID check in axp20x_usb_power_set_property
>    (it seemed more correct than adding another comment) (6)
>  - Add Reviewed-by where there were no comments (2-4, 7-8)
> 
> Changes since v1:
>  - Add patches 1-2
>  - Shift value properly in calls to regmap_update_bits (3, 7)
>  - Use #ifdef instead of #if to avoid -Wundef warnings (4, 8)
>  - Poll once after an IRQ, instead of setting power->online in the IRQ (9)
>  - Poll once on resume, in case the state changed during suspend (9)
> 
> Samuel Holland (4):
>   power: supply: axp20x_usb_power: Use a match structure
>   power: supply: axp20x_usb_power: Allow offlining
>   power: supply: axp20x_usb_power: Add wakeup control
>   power: supply: axp20x_usb_power: Only poll while offline
> 
>  drivers/power/supply/axp20x_usb_power.c | 217 ++++++++++++++++++------
>  1 file changed, 169 insertions(+), 48 deletions(-)
> 
> -- 
> 2.23.0
>