mbox series

[0/2] thermal: int340x: processor_thermal: Add new PCI MMIO based thermal driver

Message ID 20210525204811.3793651-1-srinivas.pandruvada@linux.intel.com (mailing list archive)
Headers show
Series thermal: int340x: processor_thermal: Add new PCI MMIO based thermal driver | expand

Message

srinivas pandruvada May 25, 2021, 8:48 p.m. UTC 
This series adds a new thermal driver, which uses PCI MMIO for temperature and trips. To reuse
the code the first patch just reorganizes the existing code.

This series needs the following patch to cleanly apply:
[PATCH 1/2] thermal: int340x: processor_thermal: Export mailbox interface
sent on 16th May, 21.

Srinivas Pandruvada (2):
  thermal: int340x: processor_thermal: Split enumeration and processing
    part
  thermal: int340x: processor_thermal: Add PCI MMIO based thermal driver

 .../thermal/intel/int340x_thermal/Makefile    |   3 +
 .../intel/int340x_thermal/int3401_thermal.c   |  82 ++++
 .../processor_thermal_device.c                | 289 ++------------
 .../processor_thermal_device.h                |   9 +-
 .../processor_thermal_device_pci.c            | 371 ++++++++++++++++++
 .../processor_thermal_device_pci_legacy.c     | 163 ++++++++
 6 files changed, 658 insertions(+), 259 deletions(-)
 create mode 100644 drivers/thermal/intel/int340x_thermal/int3401_thermal.c
 create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
 create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci_legacy.c

Comments

srinivas pandruvada June 24, 2021, 4:19 p.m. UTC | #1 
On Tue, 2021-05-25 at 13:48 -0700, Srinivas Pandruvada wrote:
> This series adds a new thermal driver, which uses PCI MMIO for
> temperature and trips. To reuse
> the code the first patch just reorganizes the existing code.
> 
Any comments on this series?

Thanks,
Srinivas

> This series needs the following patch to cleanly apply:
> [PATCH 1/2] thermal: int340x: processor_thermal: Export mailbox
> interface
> sent on 16th May, 21.
> 
> Srinivas Pandruvada (2):
>   thermal: int340x: processor_thermal: Split enumeration and
> processing
>     part
>   thermal: int340x: processor_thermal: Add PCI MMIO based thermal
> driver
> 
>  .../thermal/intel/int340x_thermal/Makefile    |   3 +
>  .../intel/int340x_thermal/int3401_thermal.c   |  82 ++++
>  .../processor_thermal_device.c                | 289 ++------------
>  .../processor_thermal_device.h                |   9 +-
>  .../processor_thermal_device_pci.c            | 371
> ++++++++++++++++++
>  .../processor_thermal_device_pci_legacy.c     | 163 ++++++++
>  6 files changed, 658 insertions(+), 259 deletions(-)
>  create mode 100644
> drivers/thermal/intel/int340x_thermal/int3401_thermal.c
>  create mode 100644
> drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
>  create mode 100644
> drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci_le
> gacy.c
>
Daniel Lezcano June 24, 2021, 5:04 p.m. UTC | #2 
On 24/06/2021 18:19, Srinivas Pandruvada wrote:
> On Tue, 2021-05-25 at 13:48 -0700, Srinivas Pandruvada wrote:
>> This series adds a new thermal driver, which uses PCI MMIO for
>> temperature and trips. To reuse
>> the code the first patch just reorganizes the existing code.
>>
> Any comments on this series?

I've been through the series and it looks fine for me. Except a typo in
the log 'anabled' but I fixed it.
srinivas pandruvada June 24, 2021, 6:04 p.m. UTC | #3 
On Thu, 2021-06-24 at 19:04 +0200, Daniel Lezcano wrote:
> On 24/06/2021 18:19, Srinivas Pandruvada wrote:
> > On Tue, 2021-05-25 at 13:48 -0700, Srinivas Pandruvada wrote:
> > > This series adds a new thermal driver, which uses PCI MMIO for
> > > temperature and trips. To reuse
> > > the code the first patch just reorganizes the existing code.
> > > 
> > Any comments on this series?
> 
> I've been through the series and it looks fine for me. Except a typo
> in
> the log 'anabled' but I fixed it.
Thanks Daniel.

-Srinivas

> 
> 
>
You-Sheng Yang July 6, 2021, 8:28 a.m. UTC | #4 
Verified this initialize [8086:461d] correctly. An additional thermal
zone TCPU_PCI added.

Tested-by: You-Sheng Yang <vicamo.yang@canonical.com>

On 5/26/21 4:48 AM, Srinivas Pandruvada wrote:
> This series adds a new thermal driver, which uses PCI MMIO for temperature and trips. To reuse
> the code the first patch just reorganizes the existing code.
> 
> This series needs the following patch to cleanly apply:
> [PATCH 1/2] thermal: int340x: processor_thermal: Export mailbox interface
> sent on 16th May, 21.
> 
> Srinivas Pandruvada (2):
>   thermal: int340x: processor_thermal: Split enumeration and processing
>     part
>   thermal: int340x: processor_thermal: Add PCI MMIO based thermal driver
> 
>  .../thermal/intel/int340x_thermal/Makefile    |   3 +
>  .../intel/int340x_thermal/int3401_thermal.c   |  82 ++++
>  .../processor_thermal_device.c                | 289 ++------------
>  .../processor_thermal_device.h                |   9 +-
>  .../processor_thermal_device_pci.c            | 371 ++++++++++++++++++
>  .../processor_thermal_device_pci_legacy.c     | 163 ++++++++
>  6 files changed, 658 insertions(+), 259 deletions(-)
>  create mode 100644 drivers/thermal/intel/int340x_thermal/int3401_thermal.c
>  create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
>  create mode 100644 drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci_legacy.c
>