[0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration

Message

Johan Hovold March 13, 2023, 8:49 a.m. UTC

Christophe noticed that a recent patch adding a missing clock disable to
one of the Qualcomm rpm driver error paths was broken. This would lead
to the provider not being registered on msm8996 which is the only
platform using this code path.

Turns out, however, that the power domain attach during probe is bogus
and would always succeed as any power domain would already have been
attached by the platform bus code.

Georgi, the offending commit is currently in your icc-next (and local
icc-fixes) branch. Perhaps you can fold in the fixup unless you prefer
applying it on top.

The bogus PM domain lookup is redundant and confusing but should
otherwise be benign so the removal could be applied to either branch.

Johan


Johan Hovold (2):
  interconnect: qcom: rpm: fix msm8996 interconnect registration
  interconnect: qcom: rpm: drop bogus pm domain attach

 drivers/interconnect/qcom/icc-rpm.c | 5 -----
 drivers/interconnect/qcom/icc-rpm.h | 1 -
 drivers/interconnect/qcom/msm8996.c | 1 -
 3 files changed, 7 deletions(-)

Comments

Georgi Djakov March 13, 2023, 7:57 p.m. UTC | #1

Hi Johan,

Thank you for all the fixes!

On 13.03.23 10:49, Johan Hovold wrote:
> Christophe noticed that a recent patch adding a missing clock disable to
> one of the Qualcomm rpm driver error paths was broken. This would lead
> to the provider not being registered on msm8996 which is the only
> platform using this code path.

Thanks Christophe for catching this!

> Turns out, however, that the power domain attach during probe is bogus
> and would always succeed as any power domain would already have been
> attached by the platform bus code.

Thanks Konrad for testing and confirming!

> Georgi, the offending commit is currently in your icc-next (and local
> icc-fixes) branch. Perhaps you can fold in the fixup unless you prefer
> applying it on top.
> 
> The bogus PM domain lookup is redundant and confusing but should
> otherwise be benign so the removal could be applied to either branch.

Maybe then I'll just drop this:
	interconnect: qcom: rpm: fix probe PM domain error handling
and apply this one instead:
	interconnect: qcom: rpm: drop bogus pm domain attach

BR,
Georgi

> 
> Johan
> 
> 
> Johan Hovold (2):
>    interconnect: qcom: rpm: fix msm8996 interconnect registration
>    interconnect: qcom: rpm: drop bogus pm domain attach
> 
>   drivers/interconnect/qcom/icc-rpm.c | 5 -----
>   drivers/interconnect/qcom/icc-rpm.h | 1 -
>   drivers/interconnect/qcom/msm8996.c | 1 -
>   3 files changed, 7 deletions(-)
>

Johan Hovold March 14, 2023, 7:45 a.m. UTC | #2

On Mon, Mar 13, 2023 at 09:57:37PM +0200, Georgi Djakov wrote:

> > Georgi, the offending commit is currently in your icc-next (and local
> > icc-fixes) branch. Perhaps you can fold in the fixup unless you prefer
> > applying it on top.
> > 
> > The bogus PM domain lookup is redundant and confusing but should
> > otherwise be benign so the removal could be applied to either branch.
> 
> Maybe then I'll just drop this:
> 	interconnect: qcom: rpm: fix probe PM domain error handling
> and apply this one instead:
> 	interconnect: qcom: rpm: drop bogus pm domain attach

Sure, that works too. Wasn't sure whether you preferred incremental
fixes on top or not.

I've checked the end result in linux-next against my local branch and
everything looks good.

Thanks for getting that sorted. 

Johan