mbox series

[0/5] PM: domains: Drop pm_genpd_opp_to_performance_state()

Message ID 20231012152108.101270-1-ulf.hansson@linaro.org (mailing list archive)
Headers show
Series PM: domains: Drop pm_genpd_opp_to_performance_state() | expand

Message

Ulf Hansson Oct. 12, 2023, 3:21 p.m. UTC
Since commit 7c41cdcd3bbe ("OPP: Simplify the over-designed pstate <-> level
dance"), there is no longer any users of the
pm_genpd_opp_to_performance_state() API, while a few genpd providers are still
assigning the redundant ->opp_to_performance_state() callback.

Let's clean this up so we can drop pm_genpd_opp_to_performance_state() and the
callback too.

Rafael, I would like to take this through my pmdomain tree, unless you see a
problem with it ofcourse, hence I need your ack on the last patch in the series.

Kind regards
Uffe


Ulf Hansson (5):
  soc/tegra: pmc: Drop the ->opp_to_performance_state() callback
  pmdomain: qcom: cpr: Drop the ->opp_to_performance_state() callback
  pmdomain: qcom: rpmpd: Drop the ->opp_to_performance_state() callback
  pmdomain: qcom: rpmhpd: Drop the ->opp_to_performance_state() callback
  PM: domains: Drop the unused pm_genpd_opp_to_performance_state()

 drivers/base/power/domain.c    | 32 --------------------------------
 drivers/pmdomain/qcom/cpr.c    |  7 -------
 drivers/pmdomain/qcom/rpmhpd.c |  7 -------
 drivers/pmdomain/qcom/rpmpd.c  |  7 -------
 drivers/soc/tegra/pmc.c        |  8 --------
 include/linux/pm_domain.h      | 12 ------------
 6 files changed, 73 deletions(-)

Comments

Konrad Dybcio Oct. 12, 2023, 4:19 p.m. UTC | #1
On 10/12/23 17:21, Ulf Hansson wrote:
> Since commit 7c41cdcd3bbe ("OPP: Simplify the over-designed pstate <-> level
> dance"), there is no longer any users of the
> pm_genpd_opp_to_performance_state() API, while a few genpd providers are still
> assigning the redundant ->opp_to_performance_state() callback.
> 
> Let's clean this up so we can drop pm_genpd_opp_to_performance_state() and the
> callback too.
> 
> Rafael, I would like to take this through my pmdomain tree, unless you see a
> problem with it ofcourse, hence I need your ack on the last patch in the series.
> 
> Kind regards
> Uffe
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Thierry Reding Oct. 13, 2023, 11:59 a.m. UTC | #2
From: Thierry Reding <treding@nvidia.com>


On Thu, 12 Oct 2023 17:21:08 +0200, Ulf Hansson wrote:
> Since commit 7c41cdcd3bbe ("OPP: Simplify the over-designed pstate <-> level
> dance"), there is no longer any users of the
> pm_genpd_opp_to_performance_state() API, while a few genpd providers are still
> assigning the redundant ->opp_to_performance_state() callback.
> 
> Let's clean this up so we can drop pm_genpd_opp_to_performance_state() and the
> callback too.
> 
> [...]

Applied, thanks!

[1/5] soc/tegra: pmc: Drop the ->opp_to_performance_state() callback
      commit: cda263907a6f88c75fb97cf7adecffaafb6237ec

Best regards,
Ulf Hansson Oct. 16, 2023, 9:57 a.m. UTC | #3
On Fri, 13 Oct 2023 at 13:59, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> From: Thierry Reding <treding@nvidia.com>
>
>
> On Thu, 12 Oct 2023 17:21:08 +0200, Ulf Hansson wrote:
> > Since commit 7c41cdcd3bbe ("OPP: Simplify the over-designed pstate <-> level
> > dance"), there is no longer any users of the
> > pm_genpd_opp_to_performance_state() API, while a few genpd providers are still
> > assigning the redundant ->opp_to_performance_state() callback.
> >
> > Let's clean this up so we can drop pm_genpd_opp_to_performance_state() and the
> > callback too.
> >
> > [...]
>
> Applied, thanks!
>
> [1/5] soc/tegra: pmc: Drop the ->opp_to_performance_state() callback
>       commit: cda263907a6f88c75fb97cf7adecffaafb6237ec

Thierry, I was planning to queue up the complete series through my
pmdomain tree, my apologies if that wasn't clear. I want to get rid of
the actual genpd API and the genpd callback altogether (patch5).

Would it be possible for you to drop the above patch from your tree
and provide an ack instead?

Kind regards
Uffe
Ulf Hansson Oct. 17, 2023, 11:53 a.m. UTC | #4
On Mon, 16 Oct 2023 at 11:57, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Fri, 13 Oct 2023 at 13:59, Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > From: Thierry Reding <treding@nvidia.com>
> >
> >
> > On Thu, 12 Oct 2023 17:21:08 +0200, Ulf Hansson wrote:
> > > Since commit 7c41cdcd3bbe ("OPP: Simplify the over-designed pstate <-> level
> > > dance"), there is no longer any users of the
> > > pm_genpd_opp_to_performance_state() API, while a few genpd providers are still
> > > assigning the redundant ->opp_to_performance_state() callback.
> > >
> > > Let's clean this up so we can drop pm_genpd_opp_to_performance_state() and the
> > > callback too.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/5] soc/tegra: pmc: Drop the ->opp_to_performance_state() callback
> >       commit: cda263907a6f88c75fb97cf7adecffaafb6237ec
>
> Thierry, I was planning to queue up the complete series through my
> pmdomain tree, my apologies if that wasn't clear. I want to get rid of
> the actual genpd API and the genpd callback altogether (patch5).
>
> Would it be possible for you to drop the above patch from your tree
> and provide an ack instead?

I just noticed that the above went has also been pulled into the soc
tree from your pull-request. So nevermind, I can do the final cleanup
later on.

Kind regards
Uffe