mbox series

[V2,0/2] PM: wakeup: make device_wakeup_disable return void

Message ID 20240318151631.1621881-1-d-gole@ti.com (mailing list archive)
Headers show
Series PM: wakeup: make device_wakeup_disable return void | expand

Message

Dhruva Gole March 18, 2024, 3:16 p.m. UTC 
This is a follow up patch based on discussions with Rafael[0] on a previous
patch I sent to propagate return value from device_wakeup_disable
further upward inside device_init_wakeup

However, it doesn't seem like today any return values from
device_wakeup_disable are very useful to the caller.

I could only spot one caller of this function that was actually
propagating the return value upward other than the PM core calls. I have
tried to update sdhci-pci-core to work with the new changes

[0] https://lore.kernel.org/all/CAJZ5v0jbHwiZemtNAoM-jmgB_58VqmKUkqv4P7qrPkxWzBzMyQ@mail.gmail.com/

Changelog:

v1 --> v2:
* Squashed the mmc fix into first patch [Rafael]

Dhruva Gole (2):
  PM: wakeup: make device_wakeup_disable return void
  PM: wakeup: Remove unnecessary else from device_init_wakeup

 drivers/base/power/wakeup.c       | 11 +++++++----
 drivers/mmc/host/sdhci-pci-core.c |  2 +-
 include/linux/pm_wakeup.h         | 12 +++++-------
 3 files changed, 13 insertions(+), 12 deletions(-)

Comments

Rafael J. Wysocki April 3, 2024, 2:53 p.m. UTC | #1 
On Mon, Mar 18, 2024 at 4:17 PM Dhruva Gole <d-gole@ti.com> wrote:
>
> This is a follow up patch based on discussions with Rafael[0] on a previous
> patch I sent to propagate return value from device_wakeup_disable
> further upward inside device_init_wakeup
>
> However, it doesn't seem like today any return values from
> device_wakeup_disable are very useful to the caller.
>
> I could only spot one caller of this function that was actually
> propagating the return value upward other than the PM core calls. I have
> tried to update sdhci-pci-core to work with the new changes
>
> [0] https://lore.kernel.org/all/CAJZ5v0jbHwiZemtNAoM-jmgB_58VqmKUkqv4P7qrPkxWzBzMyQ@mail.gmail.com/
>
> Changelog:
>
> v1 --> v2:
> * Squashed the mmc fix into first patch [Rafael]
>
> Dhruva Gole (2):
>   PM: wakeup: make device_wakeup_disable return void
>   PM: wakeup: Remove unnecessary else from device_init_wakeup
>
>  drivers/base/power/wakeup.c       | 11 +++++++----
>  drivers/mmc/host/sdhci-pci-core.c |  2 +-
>  include/linux/pm_wakeup.h         | 12 +++++-------
>  3 files changed, 13 insertions(+), 12 deletions(-)
>
> --

Both patches applied as 6.10 material, thanks!