[0/2] soc: mediatek: pm-domains: solve power domain glitch issue

Message

Yu-chang Lee (李禹璋) March 25, 2024, 12:19 p.m. UTC

Hi,

This series aims to solve power-off failures and occasional SMI hang issues that
occur during camera stress tests. The issue arises because, when MTCMOS powers on
or off, signal glitches are sometimes produced. This is fairly normal, but the 
software must address it to avoid mistaking the glitch for a transaction signal.

The solutions in these patches can be summarized as follows:

1. Disable the sub-common port after turning off the Larb CG and before turning 
   off the Larb MTCMOS.
2. Use CLAMP to disable/enable the SMI common port.
3. Implement an AXI reset.
For previous discussion on the direction of the code modifications, please refer
to: https://lore.kernel.org/linux-arm-kernel/[e-mail]/


yu-chang.lee (2):
  soc: mediatek: pm-domains: add smi_larb_reset function when power on
  soc: mediatek: pm-domains: support smi clamp protection

 drivers/pmdomain/mediatek/mt8188-pm-domains.h |  69 +++++-
 drivers/pmdomain/mediatek/mtk-pm-domains.c    | 206 +++++++++++++++---
 drivers/pmdomain/mediatek/mtk-pm-domains.h    |  13 ++
 3 files changed, 255 insertions(+), 33 deletions(-)

Comments

AngeloGioacchino Del Regno March 25, 2024, 1:06 p.m. UTC | #1

Il 25/03/24 13:19, yu-chang.lee ha scritto:
> Hi,
> 
> This series aims to solve power-off failures and occasional SMI hang issues that
> occur during camera stress tests. The issue arises because, when MTCMOS powers on
> or off, signal glitches are sometimes produced. This is fairly normal, but the
> software must address it to avoid mistaking the glitch for a transaction signal.
> 
> The solutions in these patches can be summarized as follows:
> 
> 1. Disable the sub-common port after turning off the Larb CG and before turning
>     off the Larb MTCMOS.
> 2. Use CLAMP to disable/enable the SMI common port.
> 3. Implement an AXI reset.
> For previous discussion on the direction of the code modifications, please refer
> to: https://lore.kernel.org/linux-arm-kernel/[e-mail]/
> 
> 
> yu-chang.lee (2):
>    soc: mediatek: pm-domains: add smi_larb_reset function when power on
>    soc: mediatek: pm-domains: support smi clamp protection

Can you please change both commit titles to use "pmdomain: mediatek:" instead of
"soc: mediatek:"?

Thanks
Angelo

> 
>   drivers/pmdomain/mediatek/mt8188-pm-domains.h |  69 +++++-
>   drivers/pmdomain/mediatek/mtk-pm-domains.c    | 206 +++++++++++++++---
>   drivers/pmdomain/mediatek/mtk-pm-domains.h    |  13 ++
>   3 files changed, 255 insertions(+), 33 deletions(-)
>