[0/6] thermal/rapl: fixes, improvements and cleanups

Message

Zhang Rui Sept. 30, 2024, 8:17 a.m. UTC

The patches in this series are independent of each other. Keep them in
one series just for easy review and tracking.

Patch 1/6 fixes a bug introduced recently. In my test, reading the
domain info at a bogus address returns all 'f'. So the psys domain is
always probed both before and after the broke commit and there should be
no visible impact.

Patch 2/6 fixes a WARNING since 6.11-rc1. But the underlying problem is
there since the proc thermal driver was introduced. Lastest code still
handles it but with an extra WARNING. So I'm not sure if this should be
considered as -stable material or not.

Patch 3 - 6 are general improvements and cleanups.

thanks,
rui

Sumeet Pawnikar (1):
  powercap: intel_rapl_msr: Add PL4 support for Arrowlake-U

Zhang Rui (5):
  powercap: intel_rapl_tpmi: Fix bogus register reading
  thermal: proc_thermal: Fix WARNING during module unload
  powercap: intel_rapl_tpmi: Ignore minor version change
  thermal: proc_thermal: Remove MMIO RAPL cpu hotplug support
  thermal: proc_thermal: Add MMIO RAPL PL4 support

 drivers/powercap/intel_rapl_msr.c             |  1 +
 drivers/powercap/intel_rapl_tpmi.c            | 19 +++--
 .../processor_thermal_device_pci.c            |  2 -
 .../int340x_thermal/processor_thermal_rapl.c  | 70 +++++++------------
 4 files changed, 40 insertions(+), 52 deletions(-)

Comments

Rafael J. Wysocki Oct. 7, 2024, 6:13 p.m. UTC | #1

On Mon, Sep 30, 2024 at 10:19 AM Zhang Rui <[e-mail]> wrote:
>
> The patches in this series are independent of each other. Keep them in
> one series just for easy review and tracking.
>
> Patch 1/6 fixes a bug introduced recently. In my test, reading the
> domain info at a bogus address returns all 'f'. So the psys domain is
> always probed both before and after the broke commit and there should be
> no visible impact.
>
> Patch 2/6 fixes a WARNING since 6.11-rc1. But the underlying problem is
> there since the proc thermal driver was introduced. Lastest code still
> handles it but with an extra WARNING. So I'm not sure if this should be
> considered as -stable material or not.
>
> Patch 3 - 6 are general improvements and cleanups.
>
> thanks,
> rui
>
> Sumeet Pawnikar (1):
>   powercap: intel_rapl_msr: Add PL4 support for Arrowlake-U
>
> Zhang Rui (5):
>   powercap: intel_rapl_tpmi: Fix bogus register reading
>   thermal: proc_thermal: Fix WARNING during module unload
>   powercap: intel_rapl_tpmi: Ignore minor version change
>   thermal: proc_thermal: Remove MMIO RAPL cpu hotplug support
>   thermal: proc_thermal: Add MMIO RAPL PL4 support
>
>  drivers/powercap/intel_rapl_msr.c             |  1 +
>  drivers/powercap/intel_rapl_tpmi.c            | 19 +++--
>  .../processor_thermal_device_pci.c            |  2 -
>  .../int340x_thermal/processor_thermal_rapl.c  | 70 +++++++------------
>  4 files changed, 40 insertions(+), 52 deletions(-)
>
> --

All applied as 6.12-rc material, thanks!