mbox series

[0/4] tools/power turbostat: Improve handling for unsupported platforms

Message ID 20241203075119.584419-1-rui.zhang@intel.com (mailing list archive)
Headers show
Series tools/power turbostat: Improve handling for unsupported platforms | expand

Message

Zhang, Rui Dec. 3, 2024, 7:51 a.m. UTC
Hi, all,

Turbostat requires per-platform enabling for different platforms due to
platform-specific features. When running on unsupported platforms,
turbostat currently operates with limited default features, which can
lead to users unknowingly using an outdated version of the tool.

Enhance turbostat to
1. exit by default when run on unsupported X86 Vendors/Intel models.
2. give a clear message to users, informing them that their CPU model is
   not supported and advising them to update to the latest version of
   turbostat for full functionality.
3. allow force loading with minimum support on unsupported platforms by
   introducing a new '--force' parameter.

With above patches, when turbostat runs
1. on supported platforms, no functional change.
2. on unsupported X86 Vendors or unsupported Intel Models without
   '--force' parameter, turbostat exits with below message:

"Unsupported platform detected.
	Use "--force" parameter to launch turbostat with minimum default support.
	To get latest turbostat support, please contact
	   lenb@kernel.org
	or pull from
	   https://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux.git turbostat"
	   
3. on unsupported X86 Vendors or unsupported Intel Models with '--force'
   parameter, turbostat continues but with below message
   
"Unsupported platform detected. Force running with minimum default support."

Any comments are welcome.

thanks,
rui

Zhang Rui (4):
  tools/power turbostat: Exit on unsupported Intel models
  tools/power turbostat: Exit on unsupported Vendors
  tools/power turbostat: Improve --help output
  tools/power turbostat: Introduce --force parameter

 tools/power/x86/turbostat/turbostat.c | 72 ++++++++++++++++++++-------
 1 file changed, 54 insertions(+), 18 deletions(-)