mbox series

[v6,0/2] Enable cpufreq for IPQ5332 & IPQ9574

Message ID cover.1698735972.git.quic_varada@quicinc.com (mailing list archive)
Headers show
Series Enable cpufreq for IPQ5332 & IPQ9574 | expand

Message

Varadarajan Narayanan Oct. 31, 2023, 7:11 a.m. UTC
This patch series aims to enable cpufreq for IPQ5332 and IPQ9574.
For IPQ5332, a minor enhancement to Stromer Plus ops and a safe
source switch is needed before cpu freq can be enabled.

These are also included in this series. Posting this as a single
series. Please let me know if this is not correct, will split in
the subsequent revisions.

Passed the following DT related validations
make W=1 ARCH=arm64 -j16 DT_CHECKER_FLAGS='-v -m' dt_binding_check DT_SCHEMA_FILES=qcom
make W=1 ARCH=arm64 -j16 CHECK_DTBS=y DT_SCHEMA_FILES=qcom dtbs_check

For IPQ5332:
~~~~~~~~~~~
	* This patch series introduces stromer plus ops which
	  builds on stromer ops and implements a different
	  set_rate and determine_rate.

	  A different set_rate is needed since stromer plus PLLs
	  do not support dynamic frequency scaling. To switch
	  between frequencies, we have to shut down the PLL,
	  configure the L and ALPHA values and turn on again. So
	  introduce the separate set of ops for Stromer Plus PLL.

	* Update ipq_pll_stromer_plus to use clk_alpha_pll_stromer_plus_ops
	  instead of clk_alpha_pll_stromer_ops.

	* Set 'l' value to a value that is supported on all SKUs.

	* Provide safe source switch for a53pll

	* Include IPQ5332 in cpufreq nvmem framework

	* Add OPP details to device tree

For IPQ9574:
~~~~~~~~~~~
	* Include IPQ9574 in cpufreq nvmem framework

	* Add OPP details to device tree

Removed 2 patches from V1 as they have been merged
	* dt-bindings: cpufreq: qcom-cpufreq-nvmem: document IPQ5332
	* dt-bindings: cpufreq: qcom-cpufreq-nvmem: document IPQ9574

v4:	Included a patch to fix 'kernel test robot' build error --
	https://lore.kernel.org/r/202310181650.g8THtfsm-lkp@intel.com/

v5:	Use devm_clk_notifier_register
	Merge IPQ53xx and IPQ95xx cases with APQ8096 for speed bin selection
	Add reviewed by tags

v6:	Except these 2 patches, rest have been merged...
	Rebased these to latest top as they don't apply cleanly
	(https://lore.kernel.org/linux-arm-msm/20231025062508.vccrmkem45p3fnwe@vireshk-i7/)

Varadarajan Narayanan (2):
  cpufreq: qti: Enable cpufreq for ipq53xx
  cpufreq: qti: Introduce cpufreq for ipq95xx

 drivers/cpufreq/cpufreq-dt-platdev.c |  2 ++
 drivers/cpufreq/qcom-cpufreq-nvmem.c | 12 ++++++++++++
 2 files changed, 14 insertions(+)

Comments

Viresh Kumar Oct. 31, 2023, 8:44 a.m. UTC | #1
On 31-10-23, 12:41, Varadarajan Narayanan wrote:
> This patch series aims to enable cpufreq for IPQ5332 and IPQ9574.
> For IPQ5332, a minor enhancement to Stromer Plus ops and a safe
> source switch is needed before cpu freq can be enabled.
> 
> These are also included in this series. Posting this as a single
> series. Please let me know if this is not correct, will split in
> the subsequent revisions.
> 
> Passed the following DT related validations
> make W=1 ARCH=arm64 -j16 DT_CHECKER_FLAGS='-v -m' dt_binding_check DT_SCHEMA_FILES=qcom
> make W=1 ARCH=arm64 -j16 CHECK_DTBS=y DT_SCHEMA_FILES=qcom dtbs_check
> 
> For IPQ5332:
> ~~~~~~~~~~~
> 	* This patch series introduces stromer plus ops which
> 	  builds on stromer ops and implements a different
> 	  set_rate and determine_rate.
> 
> 	  A different set_rate is needed since stromer plus PLLs
> 	  do not support dynamic frequency scaling. To switch
> 	  between frequencies, we have to shut down the PLL,
> 	  configure the L and ALPHA values and turn on again. So
> 	  introduce the separate set of ops for Stromer Plus PLL.
> 
> 	* Update ipq_pll_stromer_plus to use clk_alpha_pll_stromer_plus_ops
> 	  instead of clk_alpha_pll_stromer_ops.
> 
> 	* Set 'l' value to a value that is supported on all SKUs.
> 
> 	* Provide safe source switch for a53pll
> 
> 	* Include IPQ5332 in cpufreq nvmem framework
> 
> 	* Add OPP details to device tree
> 
> For IPQ9574:
> ~~~~~~~~~~~
> 	* Include IPQ9574 in cpufreq nvmem framework
> 
> 	* Add OPP details to device tree
> 
> Removed 2 patches from V1 as they have been merged
> 	* dt-bindings: cpufreq: qcom-cpufreq-nvmem: document IPQ5332
> 	* dt-bindings: cpufreq: qcom-cpufreq-nvmem: document IPQ9574
> 
> v4:	Included a patch to fix 'kernel test robot' build error --
> 	https://lore.kernel.org/r/202310181650.g8THtfsm-lkp@intel.com/
> 
> v5:	Use devm_clk_notifier_register
> 	Merge IPQ53xx and IPQ95xx cases with APQ8096 for speed bin selection
> 	Add reviewed by tags
> 
> v6:	Except these 2 patches, rest have been merged...
> 	Rebased these to latest top as they don't apply cleanly
> 	(https://lore.kernel.org/linux-arm-msm/20231025062508.vccrmkem45p3fnwe@vireshk-i7/)
> 
> Varadarajan Narayanan (2):
>   cpufreq: qti: Enable cpufreq for ipq53xx
>   cpufreq: qti: Introduce cpufreq for ipq95xx
> 
>  drivers/cpufreq/cpufreq-dt-platdev.c |  2 ++
>  drivers/cpufreq/qcom-cpufreq-nvmem.c | 12 ++++++++++++
>  2 files changed, 14 insertions(+)

Applied. Thanks.