From patchwork Mon Oct 21 01:52:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3074181 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E1AE79F396 for ; Mon, 21 Oct 2013 01:52:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2DB8A20364 for ; Mon, 21 Oct 2013 01:52:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4F34320430 for ; Mon, 21 Oct 2013 01:52:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138Ab3JUBwY (ORCPT ); Sun, 20 Oct 2013 21:52:24 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:55414 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101Ab3JUBwX (ORCPT ); Sun, 20 Oct 2013 21:52:23 -0400 Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MUZ00IJPX6PEL70@mailout1.samsung.com>; Mon, 21 Oct 2013 10:52:16 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id D4.A3.06969.FC884625; Mon, 21 Oct 2013 10:52:15 +0900 (KST) X-AuditID: cbfee68f-b7f836d000001b39-d3-526488cf6af4 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id A0.14.08134.FC884625; Mon, 21 Oct 2013 10:52:15 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MUZ00KBBX73S320@mmp2.samsung.com>; Mon, 21 Oct 2013 10:52:15 +0900 (KST) From: Jingoo Han To: "'Rafael J. Wysocki'" , linux-pm@vger.kernel.org Cc: 'Kukjin Kim' , 'Daniel Lezcano' , 'Tomasz Figa' , 'Amit Daniel Kachhap' , 'Bartlomiej Zolnierkiewicz' , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 'Jingoo Han' Subject: [PATCH 1/2] ARM: EXYNOS: Use dev_err() instead of printk() for cpuidle driver Date: Mon, 21 Oct 2013 10:52:15 +0900 Message-id: <003601cece00$2affeba0$80ffc2e0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac7OACrLPK7Vosr9TAO9hX3+rOBtOw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t8zY93zHSlBBqfnW1o0XA2x2DhjPavF vM+yFpcXXmK16F1wlc1i0+NrrBafe48wWsw4v4/Jon9hL5PF+hmvWRy4PO5c28PmsXlJvUff llWMHo8WtzB6fN4kF8AaxWWTkpqTWZZapG+XwJXx5nQ/a0EDZ8Xxh4dZGxg3sHcxcnJICJhI LLn/lxnCFpO4cG89WxcjF4eQwDJGiXsvJjPCFD16fJ8ZIjGdUeLTkfvsEM4vRonfk2ewgFSx CahJfPlyGGysiICjxMEbbUwgRcwCd5gkLrVdAhslLBAh0fBjHROIzSKgKjHn1nSwZl4BW4mb fSfZIGxBiR+T74HFmQW0JNbvPM4EYctLbF7zFugMDqCT1CUe/dWF2KUncefJZ2aIEhGJfS/e MYLslRB4yS5xoeEiC8QuAYlvkw+xQPTKSmw6APWypMTBFTdYJjCKzUKyeRaSzbOQbJ6FZMUC RpZVjKKpBckFxUnpRcZ6xYm5xaV56XrJ+bmbGCGR2r+D8e4B60OMyUDrJzJLiSbnAyM9ryTe 0NjMyMLUxNTYyNzSjDRhJXHe+w+TgoQE0hNLUrNTUwtSi+KLSnNSiw8xMnFwSjUwLs62sVt9 d6eJyTQpCT7VXNPt0laHn6b8s7FmX/X5HOP/RU9iLy0xaT3yJvtExZf/T4QX13s5Pm7S+2a1 s3L/pe65Ht3/uMsvMDZ8vuLL+OBVpsw9B42buh0hmVlvpeKMQ01rOA/xt/6Xa13wICnjkOEt R0E3Jzed12wz99/tF5si0fznpGmBEktxRqKhFnNRcSIAwpI9KeoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCKsWRmVeSWpSXmKPExsVy+t9jQd3zHSlBBg9Wm1g0XA2x2DhjPavF vM+yFpcXXmK16F1wlc1i0+NrrBafe48wWsw4v4/Jon9hL5PF+hmvWRy4PO5c28PmsXlJvUff llWMHo8WtzB6fN4kF8Aa1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeY m2qr5OIToOuWmQN0k5JCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsI4x483p ftaCBs6K4w8PszYwbmDvYuTkkBAwkXj0+D4zhC0mceHeerYuRi4OIYHpjBKfjtxnh3B+MUr8 njyDBaSKTUBN4suXw2DdIgKOEgdvtDGBFDEL3GGSuNR2iREkISwQIdHwYx0TiM0ioCox59Z0 sGZeAVuJm30n2SBsQYkfk++BxZkFtCTW7zzOBGHLS2xe8xboJA6gk9QlHv3VhdilJ3HnyWdm iBIRiX0v3jFOYBSYhWTSLCSTZiGZNAtJywJGllWMoqkFyQXFSem5RnrFibnFpXnpesn5uZsY wWngmfQOxlUNFocYBTgYlXh4A1xSgoRYE8uKK3MPMUpwMCuJ8KZ6AIV4UxIrq1KL8uOLSnNS iw8xJgM9OpFZSjQ5H5ii8kriDY1NzIwsjcwsjEzMzUkTVhLnPdhqHSgkkJ5YkpqdmlqQWgSz hYmDU6qBcelcL5ub/6L57nxZo3O+5/lxDqtrs+ZWbTjdrlv0gbmmKaU3x/Pai8LT8Xv71zx5 EqydtIdV++Pad/q/r8rPU1wdsmHjdAul9LAVJ7cxuh6/+fNLXcr0JYY1tvapv/1CLvcVSH89 d4HXbfGyw6Vt7dNXHlkgsmC2hDTfo6dHJrlN36c9Sbtx+nElluKMREMt5qLiRABZyehxRwMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Change raw printk() call to dev_err() to provide a better message to userspace so it can properly identify the device. Signed-off-by: Jingoo Han --- - Based against pm-cpuidle branch - Tested on Exynos5440 arch/arm/mach-exynos/cpuidle.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 1bde6ad..6616e0f 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -206,7 +206,7 @@ static int __init exynos_cpuidle_probe(struct platform_device *pdev) ret = cpuidle_register_driver(&exynos4_idle_driver); if (ret) { - printk(KERN_ERR "CPUidle failed to register driver\n"); + dev_err(&pdev->dev, "failed to register cpuidle driver\n"); return ret; } @@ -220,7 +220,7 @@ static int __init exynos_cpuidle_probe(struct platform_device *pdev) ret = cpuidle_register_device(device); if (ret) { - printk(KERN_ERR "CPUidle register device failed\n"); + dev_err(&pdev->dev, "failed to register cpuidle device\n"); return ret; } }