| Message ID | 004201ce4a12$816b9060$8442b120$@samsung.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
Dear Jingoo, Sachin > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/thermal/rcar_thermal.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > index 8d7edd4..63c7c13 100644 > --- a/drivers/thermal/rcar_thermal.c > +++ b/drivers/thermal/rcar_thermal.c > @@ -487,8 +487,6 @@ static int rcar_thermal_remove(struct platform_device *pdev) > rcar_thermal_irq_disable(priv); > } > > - platform_set_drvdata(pdev, NULL); > - > pm_runtime_put_sync(dev); > pm_runtime_disable(dev); I got very similar patch for rcar_thermal.c from Jingoo and Sachin Subject: [PATCH 5/6] thermal: rcar: remove unnecessary platform_set_drvdata() From: Jingoo Han <jg1.han@samsung.com> Subject: [PATCH 5/6] Thermal: rcar: Remove redundant platform_set_drvdata() From: Sachin Kamat <sachin.kamat@linaro.org> I'm not sure which one will be applied, but, for both patch, Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Best regards -- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday, May 07, 2013 9:38 AM, Kuninori Morimoto wrote: > > Dear Jingoo, Sachin > > > The driver core clears the driver data to NULL after device_release > > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > > (device-core: Ensure drvdata = NULL when no driver is bound). > > Thus, it is not needed to manually clear the device driver data to NULL. > > > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > --- > > drivers/thermal/rcar_thermal.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c > > index 8d7edd4..63c7c13 100644 > > --- a/drivers/thermal/rcar_thermal.c > > +++ b/drivers/thermal/rcar_thermal.c > > @@ -487,8 +487,6 @@ static int rcar_thermal_remove(struct platform_device *pdev) > > rcar_thermal_irq_disable(priv); > > } > > > > - platform_set_drvdata(pdev, NULL); > > - > > pm_runtime_put_sync(dev); > > pm_runtime_disable(dev); > > I got very similar patch for rcar_thermal.c > from Jingoo and Sachin > > Subject: [PATCH 5/6] thermal: rcar: remove unnecessary platform_set_drvdata() > From: Jingoo Han <jg1.han@samsung.com> > > Subject: [PATCH 5/6] Thermal: rcar: Remove redundant platform_set_drvdata() > From: Sachin Kamat <sachin.kamat@linaro.org> > > I'm not sure which one will be applied, but, for both patch, > > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Hi Kuninori Morimoto, In this case, Sachin submitted the patchset before I did; thus, Sachin's patch will be merged. Sachin, thank you for your job. Without you, cleaning cannot be done. :) Best regards, Jingoo Han > > Best regards > -- > Kuninori Morimoto > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index 8d7edd4..63c7c13 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -487,8 +487,6 @@ static int rcar_thermal_remove(struct platform_device *pdev) rcar_thermal_irq_disable(priv); } - platform_set_drvdata(pdev, NULL); - pm_runtime_put_sync(dev); pm_runtime_disable(dev);
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/thermal/rcar_thermal.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)