| Message ID | 0ec53640f1a09e6e0d7aa1a21d1a3266c3c209c7.1518166039.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote: > The "cooling-min-level" and "cooling-max-level" properties are not > parsed by any part of kernel currently and the max cooling state of a > CPU cooling device is found by referring to the cpufreq table instead. What about non-CPU devices? A fan for example. > > Remove the unused bindings. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt > index 1719d47a5e2f..cc553f0952c5 100644 > --- a/Documentation/devicetree/bindings/thermal/thermal.txt > +++ b/Documentation/devicetree/bindings/thermal/thermal.txt > @@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to > the different fan speeds possible. Cooling states are referred to by > single unsigned integers, where larger numbers mean greater heat > dissipation. The precise set of cooling states associated with a device > -(as referred to by the cooling-min-level and cooling-max-level > -properties) should be defined in a particular device's binding. > +should be defined in a particular device's binding. > For more examples of cooling devices, refer to the example sections below. > > Required properties: > @@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below. > See Cooling device maps section below for more details > on how consumers refer to cooling devices. > > -Optional properties: > -- cooling-min-level: An integer indicating the smallest > - Type: unsigned cooling state accepted. Typically 0. > - Size: one cell > - > -- cooling-max-level: An integer indicating the largest > - Type: unsigned cooling state accepted. > - Size: one cell > - > * Trip points > > The trip node is a node to describe a point in the temperature domain > @@ -226,8 +216,6 @@ cpus { > 396000 950000 > 198000 850000 > >; > - cooling-min-level = <0>; > - cooling-max-level = <3>; > #cooling-cells = <2>; /* min followed by max */ > }; > ... > @@ -241,8 +229,6 @@ cpus { > */ > fan0: fan@48 { > ... > - cooling-min-level = <0>; > - cooling-max-level = <9>; > #cooling-cells = <2>; /* min followed by max */ > }; > }; > -- > 2.15.0.194.g9af6a3dea062 >
On 18-02-18, 17:29, Rob Herring wrote: > On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote: > > The "cooling-min-level" and "cooling-max-level" properties are not > > parsed by any part of kernel currently and the max cooling state of a > > CPU cooling device is found by referring to the cpufreq table instead. > > What about non-CPU devices? A fan for example. Even they aren't using these properties. The gpio-fan binding[1] for example uses the "gpio-fan,speed-map" property instead to find the number of states it supports.
On Mon, Feb 19, 2018 at 09:13:38AM +0530, Viresh Kumar wrote: > On 18-02-18, 17:29, Rob Herring wrote: > > On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote: > > > The "cooling-min-level" and "cooling-max-level" properties are not > > > parsed by any part of kernel currently and the max cooling state of a > > > CPU cooling device is found by referring to the cpufreq table instead. > > > > What about non-CPU devices? A fan for example. > > Even they aren't using these properties. The gpio-fan binding[1] for > example uses the "gpio-fan,speed-map" property instead to find the > number of states it supports. Okay. Reviewed-by: Rob Herring <robh@kernel.org>
On 09-02-18, 14:28, Viresh Kumar wrote: > The "cooling-min-level" and "cooling-max-level" properties are not > parsed by any part of kernel currently and the max cooling state of a > CPU cooling device is found by referring to the cpufreq table instead. > > Remove the unused bindings. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > Documentation/devicetree/bindings/thermal/thermal.txt | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) @Zhang/Eduardo: Can you please pick this patch (10/10) as almost everything else is already lined up for 4.17 ?
On 一, 2018-03-12 at 10:08 +0530, Viresh Kumar wrote: > On 09-02-18, 14:28, Viresh Kumar wrote: > > > > The "cooling-min-level" and "cooling-max-level" properties are not > > parsed by any part of kernel currently and the max cooling state of > > a > > CPU cooling device is found by referring to the cpufreq table > > instead. > > > > Remove the unused bindings. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > --- > > Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---- > > ----------- > > 1 file changed, 1 insertion(+), 15 deletions(-) > @Zhang/Eduardo: Can you please pick this patch (10/10) as almost > everything else > is already lined up for 4.17 ? I think Eduardo should have reviewed all the DT thermal patches in the list, but I didn't see his response about this one. Eduardo, did you miss this one? thanks, rui >
On Tue, Mar 20, 2018 at 08:49:50PM +0800, Zhang Rui wrote: > On 一, 2018-03-12 at 10:08 +0530, Viresh Kumar wrote: > > On 09-02-18, 14:28, Viresh Kumar wrote: > > > > > > The "cooling-min-level" and "cooling-max-level" properties are not > > > parsed by any part of kernel currently and the max cooling state of > > > a > > > CPU cooling device is found by referring to the cpufreq table > > > instead. > > > > > > Remove the unused bindings. > > > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > > --- > > > Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---- > > > ----------- > > > 1 file changed, 1 insertion(+), 15 deletions(-) > > @Zhang/Eduardo: Can you please pick this patch (10/10) as almost > > everything else > > is already lined up for 4.17 ? > > I think Eduardo should have reviewed all the DT thermal patches in the > list, but I didn't see his response about this one. > > Eduardo, > did you miss this one? just applied and sending it in my pull request. > > thanks, > rui > >
diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt index 1719d47a5e2f..cc553f0952c5 100644 --- a/Documentation/devicetree/bindings/thermal/thermal.txt +++ b/Documentation/devicetree/bindings/thermal/thermal.txt @@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to the different fan speeds possible. Cooling states are referred to by single unsigned integers, where larger numbers mean greater heat dissipation. The precise set of cooling states associated with a device -(as referred to by the cooling-min-level and cooling-max-level -properties) should be defined in a particular device's binding. +should be defined in a particular device's binding. For more examples of cooling devices, refer to the example sections below. Required properties: @@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below. See Cooling device maps section below for more details on how consumers refer to cooling devices. -Optional properties: -- cooling-min-level: An integer indicating the smallest - Type: unsigned cooling state accepted. Typically 0. - Size: one cell - -- cooling-max-level: An integer indicating the largest - Type: unsigned cooling state accepted. - Size: one cell - * Trip points The trip node is a node to describe a point in the temperature domain @@ -226,8 +216,6 @@ cpus { 396000 950000 198000 850000 >; - cooling-min-level = <0>; - cooling-max-level = <3>; #cooling-cells = <2>; /* min followed by max */ }; ... @@ -241,8 +229,6 @@ cpus { */ fan0: fan@48 { ... - cooling-min-level = <0>; - cooling-max-level = <9>; #cooling-cells = <2>; /* min followed by max */ }; };
The "cooling-min-level" and "cooling-max-level" properties are not parsed by any part of kernel currently and the max cooling state of a CPU cooling device is found by referring to the cpufreq table instead. Remove the unused bindings. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- Documentation/devicetree/bindings/thermal/thermal.txt | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-)