From patchwork Thu Sep 13 13:55:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajagopal Venkat X-Patchwork-Id: 1452661 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D9C01DF24C for ; Thu, 13 Sep 2012 13:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755164Ab2IMN66 (ORCPT ); Thu, 13 Sep 2012 09:58:58 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:34264 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755137Ab2IMN65 (ORCPT ); Thu, 13 Sep 2012 09:58:57 -0400 Received: by mail-pb0-f46.google.com with SMTP id rr13so3988385pbb.19 for ; Thu, 13 Sep 2012 06:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=METTWogpQK0U7wJut0qWoGHNIrv2CS8hzv+A8+7lIr4=; b=fHCzsOWT4re+zQGuuZJNcsa7ER1j1svALxVRS5ra68yRHnleffnhCeVCcxK+ZAdTj8 OTZRjoWM4yz4jENRHkIJA672cB+BIzd0H9ldaPqAW+o/t9LC/17N2TqvLwyuPfpwmnTo fGiZ6F8k7ce4bQmM+Qfbgr9wuIZQZHhwi/3nRuge6lON+ggyqmx73LFqTj32oJ/x6YaQ 99p1ce7sL4SdDCvNAPzRUAc/VQPhjLqqR09ZSt9AhfEdioaP+e31P+2YxEZObK1PIi9L +atpBJcaPAaeCqQGguGFueHobBUs/ARmuYXztiKSvAos/XvI/Pp0XhG1OvjQuk/oKN1n ywxA== Received: by 10.68.225.168 with SMTP id rl8mr4777959pbc.115.1347544736961; Thu, 13 Sep 2012 06:58:56 -0700 (PDT) Received: from localhost.localdomain ([115.242.164.208]) by mx.google.com with ESMTPS id gh7sm13126777pbc.29.2012.09.13.06.58.51 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 13 Sep 2012 06:58:56 -0700 (PDT) From: Rajagopal Venkat To: mturquette@linaro.org, myungjoo.ham@samsung.com, kyungmin.park@samsung.com, rjw@sisk.pl Cc: patches@linaro.org, linaro-dev@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rajagopal Venkat Subject: [PATCH v2 3/3] devfreq: Add current freq callback in device profile Date: Thu, 13 Sep 2012 19:25:35 +0530 Message-Id: <1347544535-2772-4-git-send-email-rajagopal.venkat@linaro.org> X-Mailer: git-send-email 1.7.11.3 In-Reply-To: <1347544535-2772-1-git-send-email-rajagopal.venkat@linaro.org> References: <1347544535-2772-1-git-send-email-rajagopal.venkat@linaro.org> X-Gm-Message-State: ALoCoQlr4LZNmo5JWIe7wjOt79ObsJIwZQO8hc4/kT/rTLgFLhzrxjIdhKRgU6Z3PYC7DvLfHaXC Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org From: Rajagopal Venkat Devfreq returns governor predicted frequency as current frequency via sysfs interface. But device may not support all frequencies that governor predicts. So add a callback in device profile to get current freq from driver. Also add a new sysfs node to expose governor predicted next target frequency. Signed-off-by: Rajagopal Venkat --- Documentation/ABI/testing/sysfs-class-devfreq | 11 ++++++++++- drivers/devfreq/devfreq.c | 14 ++++++++++++++ include/linux/devfreq.h | 3 +++ 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-class-devfreq b/Documentation/ABI/testing/sysfs-class-devfreq index 89283b1..e6cf08e 100644 --- a/Documentation/ABI/testing/sysfs-class-devfreq +++ b/Documentation/ABI/testing/sysfs-class-devfreq @@ -19,7 +19,16 @@ Date: September 2011 Contact: MyungJoo Ham Description: The /sys/class/devfreq/.../cur_freq shows the current - frequency of the corresponding devfreq object. + frequency of the corresponding devfreq object. Same as + target_freq when get_cur_freq() is not implemented by + devfreq driver. + +What: /sys/class/devfreq/.../target_freq +Date: September 2012 +Contact: Rajagopal Venkat +Description: + The /sys/class/devfreq/.../target_freq shows the next governor + predicted target frequency of the corresponding devfreq object. What: /sys/class/devfreq/.../polling_interval Date: September 2011 diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 309c46e..049e273 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -401,6 +401,19 @@ static ssize_t show_governor(struct device *dev, static ssize_t show_freq(struct device *dev, struct device_attribute *attr, char *buf) { + unsigned long freq; + struct devfreq *devfreq = to_devfreq(dev); + + if (devfreq->profile->get_cur_freq && + !devfreq->profile->get_cur_freq(devfreq->dev.parent, &freq)) + return sprintf(buf, "%lu\n", freq); + + return sprintf(buf, "%lu\n", devfreq->previous_freq); +} + +static ssize_t show_target_freq(struct device *dev, + struct device_attribute *attr, char *buf) +{ return sprintf(buf, "%lu\n", to_devfreq(dev)->previous_freq); } @@ -504,6 +517,7 @@ static ssize_t show_max_freq(struct device *dev, struct device_attribute *attr, static struct device_attribute devfreq_attrs[] = { __ATTR(governor, S_IRUGO, show_governor, NULL), __ATTR(cur_freq, S_IRUGO, show_freq, NULL), + __ATTR(target_freq, S_IRUGO, show_target_freq, NULL), __ATTR(polling_interval, S_IRUGO | S_IWUSR, show_polling_interval, store_polling_interval), __ATTR(min_freq, S_IRUGO | S_IWUSR, show_min_freq, store_min_freq), diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h index 7c7e179..d12ed41 100644 --- a/include/linux/devfreq.h +++ b/include/linux/devfreq.h @@ -66,6 +66,8 @@ struct devfreq_dev_status { * explained above with "DEVFREQ_FLAG_*" macros. * @get_dev_status The device should provide the current performance * status to devfreq, which is used by governors. + * @get_cur_freq The device should provide the current frequency + * at which it is operating. * @exit An optional callback that is called when devfreq * is removing the devfreq object due to error or * from devfreq_remove_device() call. If the user @@ -79,6 +81,7 @@ struct devfreq_dev_profile { int (*target)(struct device *dev, unsigned long *freq, u32 flags); int (*get_dev_status)(struct device *dev, struct devfreq_dev_status *stat); + int (*get_cur_freq)(struct device *dev, unsigned long *freq); void (*exit)(struct device *dev); };