From patchwork Mon Jan 21 10:29:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2010671 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id D53D3DF23A for ; Mon, 21 Jan 2013 10:38:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135Ab3AUKis (ORCPT ); Mon, 21 Jan 2013 05:38:48 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:40341 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509Ab3AUKir (ORCPT ); Mon, 21 Jan 2013 05:38:47 -0500 Received: by mail-pb0-f43.google.com with SMTP id jt11so1886083pbb.30 for ; Mon, 21 Jan 2013 02:38:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding:x-gm-message-state; bh=P+LPVT7FFA20JKEwuj3NYRrajtoOQJrGEqN24xSTRHU=; b=BdmeXVlg1HAlKeNA455czfGxK+QdAG3FGwTXy7ZVdxOP8z4FVvKPx/J8dnIEf7RYK8 CXMbZC2Tg4YY4uQOcGPHSoqj9NxH5LgTI6C8OThZGjgMOVAWwB5uyHzr06sTr1ulZi3p KTQ8zB2JyRyS3VrUIfb/lQmc8Ha/FPbNe33mrz/zEm9EVk7frvea5fVgwIp1E12QAx7K sBsRg9Sj+S0JeaaOCQKY1VcRY8SIOdL4+/Hz1G2KvluoM7MHWlU/2GaogKtIbtoJe6Mp 5j/G2/Kd+UtuA2HdlYwkne9nOWP8+FmTaKc/of8U+rqnak802yYrxLq8NDH/IBHQpAf7 rinw== X-Received: by 10.68.234.167 with SMTP id uf7mr28461586pbc.20.1358764726991; Mon, 21 Jan 2013 02:38:46 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id oj5sm8474211pbb.47.2013.01.21.02.38.43 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jan 2013 02:38:46 -0800 (PST) From: Sachin Kamat To: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org Cc: rjw@sisk.pl, jhbird.choi@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/2] cpufreq: exynos: Initialise return variable Date: Mon, 21 Jan 2013 15:59:53 +0530 Message-Id: <1358764194-22753-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQnhLESbYnUXtoi/56yJEDC3YKHXGR5eDYuCGPnUSon9K8QGKt9lfD6dmyHzGWyANqedeg5c Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org 'ret' is undefined when the function returns from the first error condition. Without this patch we get the following warning: drivers/cpufreq/exynos-cpufreq.c: In function ‘exynos_target’: drivers/cpufreq/exynos-cpufreq.c:182:2: warning: ‘ret’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Sachin Kamat Cc: Jonghwan Choi --- drivers/cpufreq/exynos-cpufreq.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 218b3ce..38c6158 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -159,7 +159,7 @@ static int exynos_target(struct cpufreq_policy *policy, { struct cpufreq_frequency_table *freq_table = exynos_info->freq_table; unsigned int index; - int ret; + int ret = -EINVAL; mutex_lock(&cpufreq_lock); @@ -167,10 +167,8 @@ static int exynos_target(struct cpufreq_policy *policy, goto out; if (cpufreq_frequency_table_target(policy, freq_table, - target_freq, relation, &index)) { - ret = -EINVAL; + target_freq, relation, &index)) goto out; - } freqs.new = freq_table[index].frequency;