From patchwork Mon Jan 21 10:29:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2010681 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 0C1A5DF23A for ; Mon, 21 Jan 2013 10:38:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509Ab3AUKiv (ORCPT ); Mon, 21 Jan 2013 05:38:51 -0500 Received: from mail-pb0-f53.google.com ([209.85.160.53]:43833 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230Ab3AUKiu (ORCPT ); Mon, 21 Jan 2013 05:38:50 -0500 Received: by mail-pb0-f53.google.com with SMTP id un1so2603112pbc.40 for ; Mon, 21 Jan 2013 02:38:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=1dK+Ytrin+HByjYRi7JNQyzgPT0ADUMGE3RtYJ4VBow=; b=NquHvFO8twf1WoBKVDJHXnCcs8i65a9RRMK76rHqyiIn1gLbBoAT25Ucs7BBESvP9Q CYKnzO5/3NHTDjMCFXG/fazlLFGnkHc2a702dwvGD6y1J4BJX3Gd1ly6VpMTyKVsj/NU PYiDWx++7tkB/RH5Zim9mIsupCIT4S//7NryUtFzo775pu1U7wcU3zU1NPiVInx9Rp0q 91tqR3SuUEOWPBqgV/EoZN4S8q4+52R36sNGElIqxTsGY87/7bz0P82jofZ0Y1SsmKIw SZ2NyOkm1rySuZ+eRLcK6FmVif3Lq6KiHaycCTFg+Ykae5I/JSa+mUw8tEa4Ew1CLDSc NH7w== X-Received: by 10.66.82.162 with SMTP id j2mr46114983pay.13.1358764730279; Mon, 21 Jan 2013 02:38:50 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id oj5sm8474211pbb.47.2013.01.21.02.38.47 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jan 2013 02:38:49 -0800 (PST) From: Sachin Kamat To: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org Cc: rjw@sisk.pl, jhbird.choi@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/2] cpufreq: exynos: Fix unsigned variable being checked for negative value Date: Mon, 21 Jan 2013 15:59:54 +0530 Message-Id: <1358764194-22753-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1358764194-22753-1-git-send-email-sachin.kamat@linaro.org> References: <1358764194-22753-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlv8jok9KevdsD0xd6jSELjrCVGzvskZbFb3QfIKhZB5EmmQ/Bl2Gz46K/9BchS/32cmCXv Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org exynos_cpufreq_scale function returns signed value which was assigned to an unsigned variable and checked for negative value which is always false. Hence make it signed. Fixes the following smatch warnings: drivers/cpufreq/exynos-cpufreq.c:83 exynos_cpufreq_scale() warn: unsigned 'old_index' is never less than zero. drivers/cpufreq/exynos-cpufreq.c:89 exynos_cpufreq_scale() warn: unsigned 'index' is never less than zero. Signed-off-by: Sachin Kamat --- drivers/cpufreq/exynos-cpufreq.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 38c6158..4a71491 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -65,7 +65,7 @@ static int exynos_cpufreq_scale(unsigned int target_freq) struct cpufreq_policy *policy = cpufreq_cpu_get(0); unsigned int arm_volt, safe_arm_volt = 0; unsigned int mpll_freq_khz = exynos_info->mpll_freq_khz; - unsigned int index, old_index; + int index, old_index; int ret = 0; freqs.old = policy->cur;