| Message ID | 1367458508-9133-8-git-send-email-ccross@android.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, 1 May 2013, Colin Cross wrote: > Avoid waking up every thread sleeping in a futex_wait call during > suspend and resume by calling a freezable blocking call. Previous > patches modified the freezer to avoid sending wakeups to threads > that are blocked in freezable blocking calls. > > This call was selected to be converted to a freezable call because > it doesn't hold any locks or release any resources when interrupted > that might be needed by another freezing task or a kernel driver > during suspend, and is a common site where idle userspace tasks are > blocked. > > Signed-off-by: Colin Cross <ccross@android.com> Acked-by: Thomas Gleixner <tglx@linutronix.de> > --- > kernel/futex.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/futex.c b/kernel/futex.c > index b26dcfc..d710fae 100644 > --- a/kernel/futex.c > +++ b/kernel/futex.c > @@ -61,6 +61,7 @@ > #include <linux/nsproxy.h> > #include <linux/ptrace.h> > #include <linux/sched/rt.h> > +#include <linux/freezer.h> > > #include <asm/futex.h> > > @@ -1807,7 +1808,7 @@ static void futex_wait_queue_me(struct futex_hash_bucket *hb, struct futex_q *q, > * is no timeout, or if it has yet to expire. > */ > if (!timeout || timeout->task) > - schedule(); > + freezable_schedule(); > } > __set_current_state(TASK_RUNNING); > } > -- > 1.8.2.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/02/2013 12:45 PM, Thomas Gleixner wrote: > On Wed, 1 May 2013, Colin Cross wrote: > >> Avoid waking up every thread sleeping in a futex_wait call during >> suspend and resume by calling a freezable blocking call. Previous >> patches modified the freezer to avoid sending wakeups to threads >> that are blocked in freezable blocking calls. >> >> This call was selected to be converted to a freezable call because >> it doesn't hold any locks or release any resources when interrupted >> that might be needed by another freezing task or a kernel driver >> during suspend, and is a common site where idle userspace tasks are >> blocked. >> >> Signed-off-by: Colin Cross <ccross@android.com> > > Acked-by: Thomas Gleixner <tglx@linutronix.de> Beat me to it :-) Also agreed. Acked-by: Darren Hart <dvhart@linux.intel.com> > >> --- >> kernel/futex.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/kernel/futex.c b/kernel/futex.c >> index b26dcfc..d710fae 100644 >> --- a/kernel/futex.c >> +++ b/kernel/futex.c >> @@ -61,6 +61,7 @@ >> #include <linux/nsproxy.h> >> #include <linux/ptrace.h> >> #include <linux/sched/rt.h> >> +#include <linux/freezer.h> >> >> #include <asm/futex.h> >> >> @@ -1807,7 +1808,7 @@ static void futex_wait_queue_me(struct futex_hash_bucket *hb, struct futex_q *q, >> * is no timeout, or if it has yet to expire. >> */ >> if (!timeout || timeout->task) >> - schedule(); >> + freezable_schedule(); >> } >> __set_current_state(TASK_RUNNING); >> } >> -- >> 1.8.2.1 >> >>
diff --git a/kernel/futex.c b/kernel/futex.c index b26dcfc..d710fae 100644 --- a/kernel/futex.c +++ b/kernel/futex.c @@ -61,6 +61,7 @@ #include <linux/nsproxy.h> #include <linux/ptrace.h> #include <linux/sched/rt.h> +#include <linux/freezer.h> #include <asm/futex.h> @@ -1807,7 +1808,7 @@ static void futex_wait_queue_me(struct futex_hash_bucket *hb, struct futex_q *q, * is no timeout, or if it has yet to expire. */ if (!timeout || timeout->task) - schedule(); + freezable_schedule(); } __set_current_state(TASK_RUNNING); }
Avoid waking up every thread sleeping in a futex_wait call during suspend and resume by calling a freezable blocking call. Previous patches modified the freezer to avoid sending wakeups to threads that are blocked in freezable blocking calls. This call was selected to be converted to a freezable call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross <ccross@android.com> --- kernel/futex.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)