From patchwork Tue May 21 09:20:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2596581 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E8FDEDFE75 for ; Tue, 21 May 2013 09:34:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752526Ab3EUJeW (ORCPT ); Tue, 21 May 2013 05:34:22 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:63789 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507Ab3EUJeV (ORCPT ); Tue, 21 May 2013 05:34:21 -0400 Received: by mail-pa0-f52.google.com with SMTP id bg2so513942pad.25 for ; Tue, 21 May 2013 02:34:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:mime-version :content-type:content-transfer-encoding:x-gm-message-state; bh=Noj8jbR9vt/2EZ40qbe2N6eWvGiXSZzReta3fXaYJWw=; b=NWqIDvsEcMdfvPkyutrm3yE6HZn90lOGcfXhQxVDzjLig9Pd0Q/pvuVGUEalYKuhdw QYdpFChOb7KATPIHdQ7qCoQlHu3HJrekVBlW0aRGvkLwtxgxNCC0AAOX6bwzlJ8TbyDx 11IgdPoU9QMLqV3GM1k/vct2519zJ0Q0MQzuSzj64A3zygWnp3ICB4wQDCgbW/SqoMuy aN4jVOBNj/Clgoas4IZ7INB4Tpcaoi/lm71PA5Uw01q5zmx8sxFLKFGSEm80rG3VkDqZ 2JvyAEfpNb/eKsdM9bL9DKFZRJQIZNuR5fKapZFRQsXFWLgLrYXWSIEJtxbyZGvb8o4g C59w== X-Received: by 10.68.42.134 with SMTP id o6mr1747482pbl.149.1369128860986; Tue, 21 May 2013 02:34:20 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id ue8sm2592470pac.14.2013.05.21.02.34.17 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 May 2013 02:34:20 -0700 (PDT) From: Sachin Kamat To: linux-pm@vger.kernel.org Cc: eduardo.valentin@ti.com, rui.zhang@intel.com, sachin.kamat@linaro.org, Vincenzo Frascino , Viresh Kumar Subject: [PATCH 1/1] Thermal: spear: Fix compilation error Date: Tue, 21 May 2013 14:50:41 +0530 Message-Id: <1369128041-23403-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlyfJFefMM8YED+MpBeEwHi5DzHK3A+vVMkGqgvEmfgcxShck2apOefNzG/RLlPeSjxulic Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fixes the following compilation error introduced by commit 253e3ae170 (Thermal: spear_thermal: convert to devm_ioremap_resource). drivers/thermal/spear_thermal.c: In function ‘spear_thermal_probe’: drivers/thermal/spear_thermal.c:123:46: error: ‘dev’ undeclared (first use in this function) stdev->thermal_base = devm_ioremap_resource(dev, res); While at it also remove the error message as devm_ioremap_resource() provides its own error messages. Signed-off-by: Sachin Kamat Cc: Vincenzo Frascino Cc: Viresh Kumar Acked-by: Viresh Kumar Acked-by: Eduardo Valentin Tested-by: Eduardo Valentin --- Compile tested and based on linux-next (20130521). --- drivers/thermal/spear_thermal.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/spear_thermal.c b/drivers/thermal/spear_thermal.c index fa30918..813add6 100644 --- a/drivers/thermal/spear_thermal.c +++ b/drivers/thermal/spear_thermal.c @@ -120,11 +120,9 @@ static int spear_thermal_probe(struct platform_device *pdev) /* Enable thermal sensor */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - stdev->thermal_base = devm_ioremap_resource(dev, res); - if (IS_ERR(stdev->thermal_base)) { - dev_err(&pdev->dev, "ioremap failed\n"); + stdev->thermal_base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(stdev->thermal_base)) return PTR_ERR(stdev->thermal_base); - } stdev->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(stdev->clk)) {