From patchwork Wed Sep 18 05:14:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2904781 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8D32B9F1E1 for ; Wed, 18 Sep 2013 05:33:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CC116202F0 for ; Wed, 18 Sep 2013 05:33:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A57020303 for ; Wed, 18 Sep 2013 05:33:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759Ab3IRFdQ (ORCPT ); Wed, 18 Sep 2013 01:33:16 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:60913 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751652Ab3IRFdO (ORCPT ); Wed, 18 Sep 2013 01:33:14 -0400 Received: by mail-pd0-f175.google.com with SMTP id q10so6539269pdj.20 for ; Tue, 17 Sep 2013 22:33:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1fYuPv7LIrO5Q9/vShN26AajYg23ahy9Y0y9SOrM9Hg=; b=bHxgupguK22g7j1Q+qBCSp/ta++owaWN0sbRF4/9xIFTjjAP6HQ49rEfp7kkRN5/wg wb0+cxkielNo1B2jzIZbm/Puvf0veYAMosF0LIuhTZbKpjzgHCK/0bqTVu0lt8i0BSQv SvtRt+vrkrXcC/YHmfWnWCLdTRgyx59lVFE20wWtRhxd60YtxcRachfI4vt/qPS7ozmm WVFYqNfZwpMUjmF1DCOXMeTirrAmO/tO3ilPEPyV1CFkZEnb0W3rTtDdrcBhkTfNTx4T fJlErjmL4/+OlJ9doua7tk1oDSy1tOOZykCOIXqD56K+RYiYp3P55LrHBqPln+eaRFNn Ofzg== X-Gm-Message-State: ALoCoQl2EQQxa5+usF8V6brWWd5seIJCqPuXyo0/wpzYd+ClWJoZvYTsNzZl5uOlRshyrNZB/LgL X-Received: by 10.67.30.70 with SMTP id kc6mr40131728pad.32.1379482393874; Tue, 17 Sep 2013 22:33:13 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id uw6sm42663452pbc.8.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 17 Sep 2013 22:33:12 -0700 (PDT) From: Sachin Kamat To: cpufreq@vger.kernel.org Cc: linux-pm@vger.kernel.org, rjw@sisk.pl, viresh.kumar@linaro.org, sachin.kamat@linaro.org, amit.daniel@samsung.com, patches@linaro.org Subject: [PATCH 1/1] cpufreq: exynos5440: Fix potential NULL pointer dereference Date: Wed, 18 Sep 2013 10:44:53 +0530 Message-Id: <1379481293-9003-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If 'dvfs_info' is NULL (due to devm_kzalloc failure) the failure error message would try to dereference it. Use 'pdev' instead. Signed-off-by: Sachin Kamat Acked-by: Viresh Kumar --- drivers/cpufreq/exynos5440-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c index d514c15..be5380e 100644 --- a/drivers/cpufreq/exynos5440-cpufreq.c +++ b/drivers/cpufreq/exynos5440-cpufreq.c @@ -457,7 +457,7 @@ err_free_table: opp_free_cpufreq_table(dvfs_info->dev, &dvfs_info->freq_table); err_put_node: of_node_put(np); - dev_err(dvfs_info->dev, "%s: failed initialization\n", __func__); + dev_err(&pdev->dev, "%s: failed initialization\n", __func__); return ret; }