| Message ID | 1380652344-18819-4-git-send-email-eduardo.valentin@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On 14:32-20131001, Eduardo Valentin wrote: > This patch adds bandgap IP entry on DRA7 dtsi device tree file. > > Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> > --- > arch/arm/boot/dts/dra7.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 3a746c2..4e9b159 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -53,6 +53,18 @@ > }; > }; > > + bandgap: bandgap { would you like to follow bandgap: bandgap@4a0021e0 convention? Also, could you move it under ocp? I already commented about this previously here: https://lkml.org/lkml/2013/9/27/300 > + reg = <0x4a0021e0 0xc > + 0x4a00232c 0xc > + 0x4a002380 0x2c > + 0x4a0023C0 0x3c > + 0x4a002564 0x8 > + 0x4a002574 0x50>; > + compatible = "ti,dra752-bandgap"; > + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; > + #thermal-sensor-cells = <1>; > + }; > + > gic: interrupt-controller@48211000 { > compatible = "arm,cortex-a15-gic"; > interrupt-controller;
On 01-10-2013 18:46, Nishanth Menon wrote: > On 14:32-20131001, Eduardo Valentin wrote: >> This patch adds bandgap IP entry on DRA7 dtsi device tree file. >> >> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> >> --- >> arch/arm/boot/dts/dra7.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 3a746c2..4e9b159 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -53,6 +53,18 @@ >> }; >> }; >> >> + bandgap: bandgap { > would you like to follow bandgap: bandgap@4a0021e0 convention? > Also, could you move it under ocp? > I already commented about this previously here: > https://lkml.org/lkml/2013/9/27/300 yes, this can be done. > >> + reg = <0x4a0021e0 0xc >> + 0x4a00232c 0xc >> + 0x4a002380 0x2c >> + 0x4a0023C0 0x3c >> + 0x4a002564 0x8 >> + 0x4a002574 0x50>; >> + compatible = "ti,dra752-bandgap"; >> + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; >> + #thermal-sensor-cells = <1>; >> + }; >> + >> gic: interrupt-controller@48211000 { >> compatible = "arm,cortex-a15-gic"; >> interrupt-controller;
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 3a746c2..4e9b159 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -53,6 +53,18 @@ }; }; + bandgap: bandgap { + reg = <0x4a0021e0 0xc + 0x4a00232c 0xc + 0x4a002380 0x2c + 0x4a0023C0 0x3c + 0x4a002564 0x8 + 0x4a002574 0x50>; + compatible = "ti,dra752-bandgap"; + interrupts = <GIC_SPI 126 IRQ_TYPE_LEVEL_HIGH>; + #thermal-sensor-cells = <1>; + }; + gic: interrupt-controller@48211000 { compatible = "arm,cortex-a15-gic"; interrupt-controller;
This patch adds bandgap IP entry on DRA7 dtsi device tree file. Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)