diff mbox

power: Replace printks with pr_* routines

Message ID 1384531806-11500-1-git-send-email-shuah.kh@samsung.com (mailing list archive)
State RFC, archived
Headers show

Commit Message

Shuah Khan Nov. 15, 2013, 4:10 p.m. UTC 
Replaced printks with pr_* routines. dev_* routines could have been used,
but chose to use pr_* to avoid breaking scripts that might be relying on
a specific text.

Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
---
 drivers/base/power/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Greg Kroah-Hartman Nov. 15, 2013, 9:19 p.m. UTC | #1 
On Fri, Nov 15, 2013 at 09:10:06AM -0700, Shuah Khan wrote:
> Replaced printks with pr_* routines. dev_* routines could have been used,
> but chose to use pr_* to avoid breaking scripts that might be relying on
> a specific text.

I'd really like to switch to dev_* instead, even changing to pr_* should
change the output prefix (if it's set for this file, odds are it isn't
though...)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index 9f098a8..43d5dcf 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -349,7 +349,7 @@  static void pm_dev_dbg(struct device *dev, pm_message_t state, char *info)
 static void pm_dev_err(struct device *dev, pm_message_t state, char *info,
 			int error)
 {
-	printk(KERN_ERR "PM: Device %s failed to %s%s: error %d\n",
+	pr_err("PM: Device %s failed to %s%s: error %d\n",
 		dev_name(dev), pm_verb(state.event), info, error);
 }
 
@@ -1308,7 +1308,7 @@  int dpm_prepare(pm_message_t state)
 				error = 0;
 				continue;
 			}
-			printk(KERN_INFO "PM: Device %s not prepared "
+			pr_info("PM: Device %s not prepared "
 				"for power transition: code %d\n",
 				dev_name(dev), error);
 			put_device(dev);
@@ -1347,7 +1347,7 @@  EXPORT_SYMBOL_GPL(dpm_suspend_start);
 void __suspend_report_result(const char *function, void *fn, int ret)
 {
 	if (ret)
-		printk(KERN_ERR "%s(): %pF returns %d\n", function, fn, ret);
+		pr_err("%s(): %pF returns %d\n", function, fn, ret);
 }
 EXPORT_SYMBOL_GPL(__suspend_report_result);