From patchwork Thu Jan 23 16:48:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dirk.brandewie@gmail.com X-Patchwork-Id: 3529991 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2C20EC02DC for ; Thu, 23 Jan 2014 16:48:42 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0F70220181 for ; Thu, 23 Jan 2014 16:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D8A2120173 for ; Thu, 23 Jan 2014 16:48:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbaAWQsi (ORCPT ); Thu, 23 Jan 2014 11:48:38 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:41368 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751970AbaAWQsh (ORCPT ); Thu, 23 Jan 2014 11:48:37 -0500 Received: by mail-pb0-f43.google.com with SMTP id md12so2053477pbc.16 for ; Thu, 23 Jan 2014 08:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Eirali24B2fl5UPskoZ48sFkHgt/vvYyK4GLblqJV3I=; b=Gt+PUZZMksu4HITqhNNcZU5VgxenjBYjwm+pFvnTJ7omd+boDLaG5CpM8wr4AWBBYg FNRHPptmI1RAiWNg1zc5udl6la4xtx1/A8HULXnUtM3AGP5DUuA1ahBiCTwRy+ZZSkA5 gNKSLlVGFpFktA30l83SH0EoI5A9SbPlp+CPrPtqy/+Nlu2GLAHqoHlu6uTRZThY96TR OjTIWrBdz9GY3JR1KvneskTAP7t6jrmz4MUTgUBcHQsZdkTEZMOuQoi95qrpXlAecr8C L/G3UmWUGUHcRGwDGEmfIuylFNWlOzlMlfEDRXWbfx4cHNxudAuKdUEMUOvraqMCn3+S zaJQ== X-Received: by 10.68.196.195 with SMTP id io3mr9356665pbc.6.1390495717023; Thu, 23 Jan 2014 08:48:37 -0800 (PST) Received: from echolake.localdomain (static-50-43-35-129.bvtn.or.frontiernet.net. [50.43.35.129]) by mx.google.com with ESMTPSA id fk4sm63956119pab.23.2014.01.23.08.48.35 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jan 2014 08:48:36 -0800 (PST) From: dirk.brandewie@gmail.com To: rjw@rjwysocki.net, linux-pm@vger.kernel.org Cc: Dirk Brandewie Subject: [PATCH] intel_pstate: Remove periodic P state boost Date: Thu, 23 Jan 2014 08:48:27 -0800 Message-Id: <1390495707-6297-1-git-send-email-dirk.j.brandewie@intel.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dirk Brandewie Remove the periodic P state boost. This code required for some corner case benchmark tests. The calculation of the required P state was incorrect/inaccurate and would not allow P state increase. This was resolved by a combination of commits: 2134ed4 cpufreq / intel_pstate: Change to scale off of max P-state d253d2a intel_pstate: Improve accuracy by not truncating until final result reference: https://bugzilla.kernel.org/show_bug.cgi?id=64271 Reported-by: Doug Smythies Signed-off-by: Dirk Brandewie --- drivers/cpufreq/intel_pstate.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index d51f17ed..5a060eb 100644 --- a/drivers/cpufreq/intel_pstate.c +++ b/drivers/cpufreq/intel_pstate.c @@ -84,8 +84,6 @@ struct cpudata { struct pstate_data pstate; struct _pid pid; - int min_pstate_count; - u64 prev_aperf; u64 prev_mperf; int sample_ptr; @@ -568,15 +566,6 @@ static void intel_pstate_timer_func(unsigned long __data) intel_pstate_sample(cpu); intel_pstate_adjust_busy_pstate(cpu); - - if (cpu->pstate.current_pstate == cpu->pstate.min_pstate) { - cpu->min_pstate_count++; - if (!(cpu->min_pstate_count % 5)) { - intel_pstate_set_pstate(cpu, cpu->pstate.max_pstate); - } - } else - cpu->min_pstate_count = 0; - intel_pstate_set_sample_time(cpu); }