From patchwork Tue Mar 18 17:22:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: dirk.brandewie@gmail.com X-Patchwork-Id: 3854811 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E195EBF540 for ; Wed, 19 Mar 2014 17:51:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1440F2011B for ; Wed, 19 Mar 2014 17:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 444D4200DE for ; Wed, 19 Mar 2014 17:51:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756655AbaCRRXl (ORCPT ); Tue, 18 Mar 2014 13:23:41 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:41866 "EHLO mail-pb0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757237AbaCRRWz (ORCPT ); Tue, 18 Mar 2014 13:22:55 -0400 Received: by mail-pb0-f44.google.com with SMTP id rp16so7588030pbb.17 for ; Tue, 18 Mar 2014 10:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6Q+o8RtXu93QiNujPRuUHKI0Cn2CfsAf+MB5X3GLknQ=; b=Z1t7LSIFOgO84p+VU4q8kF7DSmtLYrhafRpapgdfmDWxpSyQMxdADtciW1qOIXQSIM +LABTCt4gfhxrowZw2BVRMHz1TwiWxciWAxU/p9xGDLjqiCSkTmUS4IBLuXmGKO4afla sludcNXyUtn3NTDTf4UAsArq/gTPTwf8po/iS7C/pIhql8+/gqRp/Gmhfu/iW88Sai/x L+c/kMovzrZCM1kMT4LNBd8aV0Ho7a8m5CuX4HuGKVo4Wd59DwidD6WsRY3Ksh/rWizg f8mln+vzdY6VcUUOuV4zWb9zD6EQM2X3xA00IHpL5lPVkjYkZt9f1uQc4/E5r6Up+my5 A7OA== X-Received: by 10.68.164.229 with SMTP id yt5mr33904174pbb.28.1395163375021; Tue, 18 Mar 2014 10:22:55 -0700 (PDT) Received: from echolake.localdomain (static-50-43-42-35.bvtn.or.frontiernet.net. [50.43.42.35]) by mx.google.com with ESMTPSA id qq5sm54440246pbb.24.2014.03.18.10.22.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Mar 2014 10:22:54 -0700 (PDT) From: dirk.brandewie@gmail.com To: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, rjw@rjwysocki.net, patrick.marlier@gmail.com, viresh.kumar@linaro.org, srivatsa.bhat@linux.vnet.ibm.com, dirk.brandewie@gmail.com, Dirk Brandewie Subject: [PATCH 1/2] cpufreq: Add stop callback to cpufreq_driver interface Date: Tue, 18 Mar 2014 10:22:40 -0700 Message-Id: <1395163361-26380-2-git-send-email-dirk.j.brandewie@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1395163361-26380-1-git-send-email-dirk.j.brandewie@intel.com> References: <1394831037-15553-1-git-send-email-dirk.j.brandewie@intel.com> <1395163361-26380-1-git-send-email-dirk.j.brandewie@intel.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Dirk Brandewie This callback allows the driver to do clean up before the CPU is completely down and its state cannot be modified. This is used by the intel_pstate driver to reduce the requested P state prior to the core going away. This is required because the requested P state of the offline core is used to select the package P state. This effectively sets the floor package P state to the requested P state on the offline core. Signed-off-by: Dirk Brandewie Acked-by: Viresh Kumar --- Documentation/cpu-freq/cpu-drivers.txt | 8 +++++++- drivers/cpufreq/cpufreq.c | 3 ++- include/linux/cpufreq.h | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/cpu-freq/cpu-drivers.txt b/Documentation/cpu-freq/cpu-drivers.txt index 8b1a445..79def80 100644 --- a/Documentation/cpu-freq/cpu-drivers.txt +++ b/Documentation/cpu-freq/cpu-drivers.txt @@ -61,7 +61,13 @@ target_index - See below on the differences. And optionally -cpufreq_driver.exit - A pointer to a per-CPU cleanup function. +cpufreq_driver.exit - A pointer to a per-CPU cleanup + function called during CPU_POST_DEAD + phase of cpu hotplug process. + +cpufreq_driver.stop - A pointer to a per-CPU stop function + called during CPU_DOWN_PREPARE phase of + cpu hotplug process. cpufreq_driver.resume - A pointer to a per-CPU resume function which is called with interrupts disabled diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index cf485d9..6e6beae 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1336,7 +1336,8 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, __func__, new_cpu, cpu); } } - } + } else if (cpufreq_driver->stop) + cpufreq_driver->stop(policy); return 0; } diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 4d89e0e..ff8db19 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -224,6 +224,7 @@ struct cpufreq_driver { int (*bios_limit) (int cpu, unsigned int *limit); int (*exit) (struct cpufreq_policy *policy); + int (*stop) (struct cpufreq_policy *policy); int (*suspend) (struct cpufreq_policy *policy); int (*resume) (struct cpufreq_policy *policy); struct freq_attr **attr;