diff mbox

Documentation: power: swsusp: Fix script for unswapping

Message ID 1399374116-12400-1-git-send-email-pali.rohar@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Pali Rohár May 6, 2014, 11:01 a.m. UTC
System can have mmaped also character devices (e.g dri devices by X) or deleted
files. Running cat on character devices is really bad idea (system can hang) so
run cat only on regular files. Also mmaped files can have spaces in filenames.

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 Documentation/power/swsusp.txt |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Pavel Machek Aug. 16, 2014, 3:42 p.m. UTC | #1
On Tue 2014-05-06 13:01:56, Pali Roh?r wrote:
> System can have mmaped also character devices (e.g dri devices by X) or deleted
> files. Running cat on character devices is really bad idea (system can hang) so
> run cat only on regular files. Also mmaped files can have spaces in filenames.
> 
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>

Acked-by: Pavel Machek <pavel@ucw.cz>

> ---
>  Documentation/power/swsusp.txt |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/power/swsusp.txt b/Documentation/power/swsusp.txt
> index 079160e..f732a83 100644
> --- a/Documentation/power/swsusp.txt
> +++ b/Documentation/power/swsusp.txt
> @@ -220,7 +220,10 @@ Q: After resuming, system is paging heavily, leading to very bad interactivity.
>  
>  A: Try running
>  
> -cat `cat /proc/[0-9]*/maps | grep / | sed 's:.* /:/:' | sort -u` > /dev/null
> +cat /proc/[0-9]*/maps | grep / | sed 's:.* /:/:' | sort -u | while read file
> +do
> +  test -f "$file" && cat "$file" > /dev/null
> +done
>  
>  after resume. swapoff -a; swapon -a may also be useful.
>  
> -- 
> 1.7.9.5
diff mbox

Patch

diff --git a/Documentation/power/swsusp.txt b/Documentation/power/swsusp.txt
index 079160e..f732a83 100644
--- a/Documentation/power/swsusp.txt
+++ b/Documentation/power/swsusp.txt
@@ -220,7 +220,10 @@  Q: After resuming, system is paging heavily, leading to very bad interactivity.
 
 A: Try running
 
-cat `cat /proc/[0-9]*/maps | grep / | sed 's:.* /:/:' | sort -u` > /dev/null
+cat /proc/[0-9]*/maps | grep / | sed 's:.* /:/:' | sort -u | while read file
+do
+  test -f "$file" && cat "$file" > /dev/null
+done
 
 after resume. swapoff -a; swapon -a may also be useful.