From patchwork Wed Aug 20 20:41:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 4753681 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2C14F9F4D4 for ; Wed, 20 Aug 2014 20:44:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6C8E720176 for ; Wed, 20 Aug 2014 20:44:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DF7020155 for ; Wed, 20 Aug 2014 20:44:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753253AbaHTUoB (ORCPT ); Wed, 20 Aug 2014 16:44:01 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:38605 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753084AbaHTUmt (ORCPT ); Wed, 20 Aug 2014 16:42:49 -0400 Received: by mail-pa0-f51.google.com with SMTP id ey11so12595106pad.24 for ; Wed, 20 Aug 2014 13:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=1JRY6s1tJMw4gBcunLQt9ZjqOKRn9fNLd4a5rXBR9Vk=; b=L1309Kj9ETMobkps2j2mYvps8YbNTNrDHqjptmH24/hbiX+hbHeT2yGEr/5LCga94E AP401Abgyai9KiMTivdgC+l75HfS+X87h81VAzOTRFd8Nr7xYjnhyH1X0V7f+5ZN4JJZ EVdsFWDJc8UMq2yWATKZ3JsKb0s+aiseY5uLJ8x6rqxpxuJ/WPqYddeSjdoxbAAiQGAC B1O6GsMcpLBYAUl7QbUuavRdkcjxJRoOgzOXB6EmZy+Ow3/UIvmBD1JeNj2ywW1+9OGr 54KjLEnOJuWcbvb21XY7p/0jD4rbVZrGBI2Eevy0j4Rs5ChkKhXKy1snDvASjw1tfuAX WE9g== X-Received: by 10.68.223.34 with SMTP id qr2mr55605734pbc.29.1408567363942; Wed, 20 Aug 2014 13:42:43 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id ey10sm35431337pdb.50.2014.08.20.13.42.42 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 20 Aug 2014 13:42:43 -0700 (PDT) From: Soren Brinkmann To: Michal Simek , Russell King , "Rafael J. Wysocki" , Daniel Lezcano , Rob Herring , Mark Rutland Cc: =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Pawel Moll , Ian Campbell , Kumar Gala Subject: [PATCH 6/9] ARM: zynq: cpuidle: Remove pointless code Date: Wed, 20 Aug 2014 13:41:52 -0700 Message-Id: <1408567315-28479-7-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.0.1.1.gfbfc394 In-Reply-To: <1408567315-28479-1-git-send-email-soren.brinkmann@xilinx.com> References: <1408567315-28479-1-git-send-email-soren.brinkmann@xilinx.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Daniel Lezcano The core is not powered down, it is pointless to call the cpu_pm notifiers and switch to the global timer. Signed-off-by: Daniel Lezcano Reviewed-and-tested-by: Soren Brinkmann --- drivers/cpuidle/cpuidle-zynq.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c index aded75928028..c61b8b2a7c77 100644 --- a/drivers/cpuidle/cpuidle-zynq.c +++ b/drivers/cpuidle/cpuidle-zynq.c @@ -26,7 +26,6 @@ */ #include -#include #include #include #include @@ -38,15 +37,9 @@ static int zynq_enter_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { - /* Devices must be stopped here */ - cpu_pm_enter(); - /* Add code for DDR self refresh start */ cpu_do_idle(); - /* Add code for DDR self refresh stop */ - cpu_pm_exit(); - return index; } @@ -59,8 +52,7 @@ static struct cpuidle_driver zynq_idle_driver = { .enter = zynq_enter_idle, .exit_latency = 10, .target_residency = 10000, - .flags = CPUIDLE_FLAG_TIME_VALID | - CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIME_VALID, .name = "RAM_SR", .desc = "WFI and RAM Self Refresh", },