diff mbox

[PATCHv2,4/4] cpufreq: cpufreq-dt: adjust message related to regulators

Message ID 1410350908-11316-5-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Thomas Petazzoni Sept. 10, 2014, 12:08 p.m. UTC
The cpufreq-dt driver tries to get a regulator for each CPU. This
regulator is optional, but when not present, a scary message "failed
to get cpuX regulator" is displayed. To solve this, we reduce the
severity of the message from dev_warn() to dev_dbg() and we reword the
message to not be as scary.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 drivers/cpufreq/cpufreq-dt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Viresh Kumar Sept. 10, 2014, 12:23 p.m. UTC | #1
On 10 September 2014 17:38, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> The cpufreq-dt driver tries to get a regulator for each CPU. This
> regulator is optional, but when not present, a scary message "failed
> to get cpuX regulator" is displayed. To solve this, we reduce the
> severity of the message from dev_warn() to dev_dbg() and we reword the
> message to not be as scary.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  drivers/cpufreq/cpufreq-dt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
> index 987bbfa..b14628f 100644
> --- a/drivers/cpufreq/cpufreq-dt.c
> +++ b/drivers/cpufreq/cpufreq-dt.c
> @@ -147,8 +147,8 @@ try_again:
>                         goto try_again;
>                 }
>
> -               dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n",
> -                        cpu, PTR_ERR(cpu_reg));
> +               dev_dbg(cpu_dev, "no regulator for cpu%d: %ld\n",
> +                       cpu, PTR_ERR(cpu_reg));
>         }
>
>         cpu_clk = clk_get(cpu_dev, NULL);

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c
index 987bbfa..b14628f 100644
--- a/drivers/cpufreq/cpufreq-dt.c
+++ b/drivers/cpufreq/cpufreq-dt.c
@@ -147,8 +147,8 @@  try_again:
 			goto try_again;
 		}
 
-		dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n",
-			 cpu, PTR_ERR(cpu_reg));
+		dev_dbg(cpu_dev, "no regulator for cpu%d: %ld\n",
+			cpu, PTR_ERR(cpu_reg));
 	}
 
 	cpu_clk = clk_get(cpu_dev, NULL);