From patchwork Mon Sep 22 17:07:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 4949061 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3BC919F32F for ; Mon, 22 Sep 2014 17:07:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D452F2022D for ; Mon, 22 Sep 2014 17:07:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7738420176 for ; Mon, 22 Sep 2014 17:07:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592AbaIVRHS (ORCPT ); Mon, 22 Sep 2014 13:07:18 -0400 Received: from mail-pd0-f175.google.com ([209.85.192.175]:58808 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbaIVRHQ (ORCPT ); Mon, 22 Sep 2014 13:07:16 -0400 Received: by mail-pd0-f175.google.com with SMTP id v10so3684309pde.6 for ; Mon, 22 Sep 2014 10:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=LiWB+LfIhmmcn6eVgW9pKB4/gMbCF6f5AEJVIHXSNYk=; b=dWwNs/TOp1H3A/RQcAoXqAxv0Y7m6QDhLfL0oz3pGq5o2IqS+lsS+ftzgAnkcAdmlj 1WOQELtte+cVs7ztOMBkhijuC1c6wycB7kmYHAKzZuaIkdBKd7hk4gH21IGGiRAFJI6z nLRYQcgxRQBOwJkE5mb/6rhIUry9CCoCAKYzMp0SFvBx9Dm5wIndUj8yavUB7g2Zw3NP TQH7VO1IZC698MTQnxh3X3YFhjZbd60kvUaQL6hTR1tH7R1sj8KYiXzHBtvhmnZ95YxW 9+s8c+cuKF9kZs/aDxSrs664AtdOeBcMCOQJfQYjiRz97kX6EFkyva2R8AFUIMNsgzhw yZfA== X-Received: by 10.70.131.13 with SMTP id oi13mr28600384pdb.23.1411405636216; Mon, 22 Sep 2014 10:07:16 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id st7sm9926817pab.7.2014.09.22.10.07.14 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 22 Sep 2014 10:07:14 -0700 (PDT) From: Soren Brinkmann To: Thomas Gleixner , "Rafael J. Wysocki" Cc: John Stultz , Pavel Machek , Len Brown , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Soren Brinkmann Subject: [PATCH RESEND] PM / sleep: Fix racing timers Date: Mon, 22 Sep 2014 10:07:03 -0700 Message-Id: <1411405623-7869-1-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.1.0.1.g27b9230 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On platforms that do not power off during suspend, successfully entering suspend races with timers. The race happening in a couple of location is: 1. disable IRQs (e.g. arch_suspend_disable_irqs()) ... 2. syscore_suspend() -> timekeeping_suspend() -> clockevents_notify(SUSPEND) -> tick_suspend() (timers are turned off here) ... 3. wfi (wait for wake-IRQ here) Between steps 1 and 2 the timers can still generate interrupts that are not handled and stay pending until step 3. That pending IRQ causes an immediate - spurious - wake. The solution is to move the clockevents suspend/resume notification out of the syscore_suspend step and explictly call them at the appropriate time in the suspend/hibernation paths. I.e. timers are suspend _before_ IRQs get disabled. And accordingly in the resume path. Signed-off-by: Soren Brinkmann --- Hi, there was not a lot of discussion on the last submission. Just one comment from Rafael (https://lkml.org/lkml/2014/8/26/780), which - as I outlined in my response, does not apply, IMHO, since the platform does not re-enable interrupts. Hence, I still believe fixing this in the core is the appropriate way. Thanks, Sören Changes since RFC: - remove resume notification from syscore_resume path. --- kernel/power/hibernate.c | 9 +++++++++ kernel/power/suspend.c | 5 +++++ kernel/time/timekeeping.c | 3 --- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index a9dfa79b6bab..76f15644aec8 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -285,6 +285,8 @@ static int create_image(int platform_mode) if (error || hibernation_test(TEST_CPUS)) goto Enable_cpus; + clockevents_notify(CLOCK_EVT_NOTIFY_SUSPEND, NULL); + local_irq_disable(); error = syscore_suspend(); @@ -316,6 +318,7 @@ static int create_image(int platform_mode) syscore_resume(); Enable_irqs: + clockevents_notify(CLOCK_EVT_NOTIFY_RESUME, NULL); local_irq_enable(); Enable_cpus: @@ -438,6 +441,8 @@ static int resume_target_kernel(bool platform_mode) if (error) goto Enable_cpus; + clockevents_notify(CLOCK_EVT_NOTIFY_SUSPEND, NULL); + local_irq_disable(); error = syscore_suspend(); @@ -472,6 +477,7 @@ static int resume_target_kernel(bool platform_mode) syscore_resume(); Enable_irqs: + clockevents_notify(CLOCK_EVT_NOTIFY_RESUME, NULL); local_irq_enable(); Enable_cpus: @@ -550,6 +556,8 @@ int hibernation_platform_enter(void) if (error) goto Platform_finish; + clockevents_notify(CLOCK_EVT_NOTIFY_SUSPEND, NULL); + local_irq_disable(); syscore_suspend(); if (pm_wakeup_pending()) { @@ -563,6 +571,7 @@ int hibernation_platform_enter(void) Power_up: syscore_resume(); + clockevents_notify(CLOCK_EVT_NOTIFY_RESUME, NULL); local_irq_enable(); enable_nonboot_cpus(); diff --git a/kernel/power/suspend.c b/kernel/power/suspend.c index 18c62195660f..ded3c7d6731f 100644 --- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -294,6 +295,8 @@ static int suspend_enter(suspend_state_t state, bool *wakeup) if (error || suspend_test(TEST_CPUS)) goto Enable_cpus; + clockevents_notify(CLOCK_EVT_NOTIFY_SUSPEND, NULL); + arch_suspend_disable_irqs(); BUG_ON(!irqs_disabled()); @@ -311,6 +314,8 @@ static int suspend_enter(suspend_state_t state, bool *wakeup) syscore_resume(); } + clockevents_notify(CLOCK_EVT_NOTIFY_RESUME, NULL); + arch_suspend_enable_irqs(); BUG_ON(irqs_disabled()); diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index ec1791fae965..5b6696772ffc 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -1189,8 +1189,6 @@ static void timekeeping_resume(void) touch_softlockup_watchdog(); - clockevents_notify(CLOCK_EVT_NOTIFY_RESUME, NULL); - /* Resume hrtimers */ hrtimers_resume(); } @@ -1243,7 +1241,6 @@ static int timekeeping_suspend(void) write_seqcount_end(&tk_core.seq); raw_spin_unlock_irqrestore(&timekeeper_lock, flags); - clockevents_notify(CLOCK_EVT_NOTIFY_SUSPEND, NULL); clocksource_suspend(); clockevents_suspend();