| Message ID | 1413876435-11720-5-git-send-email-mhocko@suse.cz (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Tuesday, October 21, 2014 09:27:15 AM Michal Hocko wrote: > as per 0c740d0afc3b (introduce for_each_thread() to replace the buggy > while_each_thread()) get rid of do_each_thread { } while_each_thread() > construct and replace it by a more error prone for_each_thread. > > This patch doesn't introduce any user visible change. > > Suggested-by: Oleg Nesterov <oleg@redhat.com> > Signed-off-by: Michal Hocko <mhocko@suse.cz> ACK Or do you want me to handle this series? > --- > kernel/power/process.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/kernel/power/process.c b/kernel/power/process.c > index a397fa161d11..7fd7b72554fe 100644 > --- a/kernel/power/process.c > +++ b/kernel/power/process.c > @@ -46,13 +46,13 @@ static int try_to_freeze_tasks(bool user_only) > while (true) { > todo = 0; > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > if (p == current || !freeze_task(p)) > continue; > > if (!freezer_should_skip(p)) > todo++; > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > > if (!user_only) { > @@ -93,11 +93,11 @@ static int try_to_freeze_tasks(bool user_only) > > if (!wakeup) { > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > if (p != current && !freezer_should_skip(p) > && freezing(p) && !frozen(p)) > sched_show_task(p); > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > } > } else { > @@ -219,11 +219,11 @@ void thaw_processes(void) > thaw_workqueues(); > > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > /* No other threads should have PF_SUSPEND_TASK set */ > WARN_ON((p != curr) && (p->flags & PF_SUSPEND_TASK)); > __thaw_task(p); > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > > WARN_ON(!(curr->flags & PF_SUSPEND_TASK)); > @@ -246,10 +246,10 @@ void thaw_kernel_threads(void) > thaw_workqueues(); > > read_lock(&tasklist_lock); > - do_each_thread(g, p) { > + for_each_process_thread(g, p) { > if (p->flags & (PF_KTHREAD | PF_WQ_WORKER)) > __thaw_task(p); > - } while_each_thread(g, p); > + } > read_unlock(&tasklist_lock); > > schedule(); >
On Tue 21-10-14 14:10:18, Rafael J. Wysocki wrote: > On Tuesday, October 21, 2014 09:27:15 AM Michal Hocko wrote: > > as per 0c740d0afc3b (introduce for_each_thread() to replace the buggy > > while_each_thread()) get rid of do_each_thread { } while_each_thread() > > construct and replace it by a more error prone for_each_thread. > > > > This patch doesn't introduce any user visible change. > > > > Suggested-by: Oleg Nesterov <oleg@redhat.com> > > Signed-off-by: Michal Hocko <mhocko@suse.cz> > > ACK > > Or do you want me to handle this series? I don't know, I hoped either you or Andrew to pick it up. > > --- > > kernel/power/process.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/kernel/power/process.c b/kernel/power/process.c > > index a397fa161d11..7fd7b72554fe 100644 > > --- a/kernel/power/process.c > > +++ b/kernel/power/process.c > > @@ -46,13 +46,13 @@ static int try_to_freeze_tasks(bool user_only) > > while (true) { > > todo = 0; > > read_lock(&tasklist_lock); > > - do_each_thread(g, p) { > > + for_each_process_thread(g, p) { > > if (p == current || !freeze_task(p)) > > continue; > > > > if (!freezer_should_skip(p)) > > todo++; > > - } while_each_thread(g, p); > > + } > > read_unlock(&tasklist_lock); > > > > if (!user_only) { > > @@ -93,11 +93,11 @@ static int try_to_freeze_tasks(bool user_only) > > > > if (!wakeup) { > > read_lock(&tasklist_lock); > > - do_each_thread(g, p) { > > + for_each_process_thread(g, p) { > > if (p != current && !freezer_should_skip(p) > > && freezing(p) && !frozen(p)) > > sched_show_task(p); > > - } while_each_thread(g, p); > > + } > > read_unlock(&tasklist_lock); > > } > > } else { > > @@ -219,11 +219,11 @@ void thaw_processes(void) > > thaw_workqueues(); > > > > read_lock(&tasklist_lock); > > - do_each_thread(g, p) { > > + for_each_process_thread(g, p) { > > /* No other threads should have PF_SUSPEND_TASK set */ > > WARN_ON((p != curr) && (p->flags & PF_SUSPEND_TASK)); > > __thaw_task(p); > > - } while_each_thread(g, p); > > + } > > read_unlock(&tasklist_lock); > > > > WARN_ON(!(curr->flags & PF_SUSPEND_TASK)); > > @@ -246,10 +246,10 @@ void thaw_kernel_threads(void) > > thaw_workqueues(); > > > > read_lock(&tasklist_lock); > > - do_each_thread(g, p) { > > + for_each_process_thread(g, p) { > > if (p->flags & (PF_KTHREAD | PF_WQ_WORKER)) > > __thaw_task(p); > > - } while_each_thread(g, p); > > + } > > read_unlock(&tasklist_lock); > > > > schedule(); > > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center.
On Tuesday, October 21, 2014 03:19:53 PM Michal Hocko wrote: > On Tue 21-10-14 14:10:18, Rafael J. Wysocki wrote: > > On Tuesday, October 21, 2014 09:27:15 AM Michal Hocko wrote: > > > as per 0c740d0afc3b (introduce for_each_thread() to replace the buggy > > > while_each_thread()) get rid of do_each_thread { } while_each_thread() > > > construct and replace it by a more error prone for_each_thread. > > > > > > This patch doesn't introduce any user visible change. > > > > > > Suggested-by: Oleg Nesterov <oleg@redhat.com> > > > Signed-off-by: Michal Hocko <mhocko@suse.cz> > > > > ACK > > > > Or do you want me to handle this series? > > I don't know, I hoped either you or Andrew to pick it up. OK, I will then.
diff --git a/kernel/power/process.c b/kernel/power/process.c index a397fa161d11..7fd7b72554fe 100644 --- a/kernel/power/process.c +++ b/kernel/power/process.c @@ -46,13 +46,13 @@ static int try_to_freeze_tasks(bool user_only) while (true) { todo = 0; read_lock(&tasklist_lock); - do_each_thread(g, p) { + for_each_process_thread(g, p) { if (p == current || !freeze_task(p)) continue; if (!freezer_should_skip(p)) todo++; - } while_each_thread(g, p); + } read_unlock(&tasklist_lock); if (!user_only) { @@ -93,11 +93,11 @@ static int try_to_freeze_tasks(bool user_only) if (!wakeup) { read_lock(&tasklist_lock); - do_each_thread(g, p) { + for_each_process_thread(g, p) { if (p != current && !freezer_should_skip(p) && freezing(p) && !frozen(p)) sched_show_task(p); - } while_each_thread(g, p); + } read_unlock(&tasklist_lock); } } else { @@ -219,11 +219,11 @@ void thaw_processes(void) thaw_workqueues(); read_lock(&tasklist_lock); - do_each_thread(g, p) { + for_each_process_thread(g, p) { /* No other threads should have PF_SUSPEND_TASK set */ WARN_ON((p != curr) && (p->flags & PF_SUSPEND_TASK)); __thaw_task(p); - } while_each_thread(g, p); + } read_unlock(&tasklist_lock); WARN_ON(!(curr->flags & PF_SUSPEND_TASK)); @@ -246,10 +246,10 @@ void thaw_kernel_threads(void) thaw_workqueues(); read_lock(&tasklist_lock); - do_each_thread(g, p) { + for_each_process_thread(g, p) { if (p->flags & (PF_KTHREAD | PF_WQ_WORKER)) __thaw_task(p); - } while_each_thread(g, p); + } read_unlock(&tasklist_lock); schedule();
as per 0c740d0afc3b (introduce for_each_thread() to replace the buggy while_each_thread()) get rid of do_each_thread { } while_each_thread() construct and replace it by a more error prone for_each_thread. This patch doesn't introduce any user visible change. Suggested-by: Oleg Nesterov <oleg@redhat.com> Signed-off-by: Michal Hocko <mhocko@suse.cz> --- kernel/power/process.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)