From patchwork Thu Nov 6 13:51:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grygorii Strashko X-Patchwork-Id: 5242141 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4091F9F387 for ; Thu, 6 Nov 2014 13:54:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EAF2B2011E for ; Thu, 6 Nov 2014 13:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A858B2010F for ; Thu, 6 Nov 2014 13:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751156AbaKFNxy (ORCPT ); Thu, 6 Nov 2014 08:53:54 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:48239 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbaKFNxy (ORCPT ); Thu, 6 Nov 2014 08:53:54 -0500 Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id sA6DpCij002502; Thu, 6 Nov 2014 07:51:12 -0600 Received: from DFLE73.ent.ti.com (dfle73.ent.ti.com [128.247.5.110]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id sA6DpCLQ013044; Thu, 6 Nov 2014 07:51:12 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE73.ent.ti.com (128.247.5.110) with Microsoft SMTP Server id 14.3.174.1; Thu, 6 Nov 2014 07:51:12 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id sA6DpB4p023865; Thu, 6 Nov 2014 07:51:12 -0600 From: Grygorii Strashko To: , "Rafael J. Wysocki" , CC: , Rob Herring , , , , , Grygorii Strashko , Ulf Hansson , Geert Uytterhoeven , Dmitry Torokhov , Philipp Zabel , Caesar Wang Subject: [RFC PATCH v4 3/3] PM / clock_ops: add and enable clocks always if !CONFIG_PM_RUNTIME Date: Thu, 6 Nov 2014 15:51:02 +0200 Message-ID: <1415281862-23764-4-git-send-email-grygorii.strashko@ti.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1415281862-23764-1-git-send-email-grygorii.strashko@ti.com> References: <1415281862-23764-1-git-send-email-grygorii.strashko@ti.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Device's clocks need to be enabled always at probing time if !CONFIG_PM_RUNTIME - in that way, device will become accesible and, later, its clocks can be disabled/enabled during system suspend/resume by using pm_clk_suspend/pm_clk_resume APIs. But now, the clocks management code doesn't enable clocks when clocks are being registered per-device by using pm_clk_add/_clk(). So, update pm_clk_acquire(), which is called from pm_clk_add/_clk(), to enable clock always if !CONFIG_PM_RUNTIME. Also, Platform PM domains drivers will not have to add code like below each time they need to handle the case when !CONFIG_PM_RUNTIME [1 - 3]: if (!IS_ENABLED(CONFIG_PM_RUNTIME)) { ret = pm_clk_resume(dev); if (ret) { dev_err(dev, "pm_clk_resume failed %d\n", ret); goto clk_err; }; } [1] https://lkml.org/lkml/2014/10/3/306 [2] https://lkml.org/lkml/2014/10/16/305 [3] https://lkml.org/lkml/2014/10/20/249 CC: Santosh Shilimkar CC: Kevin Hilman CC: Ulf Hansson CC: Geert Uytterhoeven CC: Dmitry Torokhov CC: Philipp Zabel CC: Caesar Wang Signed-off-by: Grygorii Strashko --- Hi, I marked it as RFC, because: Generic clock manipulation PM callbacks can be used for any device for which list of clocks need to be maintained - and it doesn't mean that this framework need to be always connected to GPD/Runtime PM or used during suspend resume. Also, for DT-use case - it doesn't perform any actions (except clk_prepare) on clocks by itself and only by request from framework's consumer. For example, it can be reused by Power domain/controller drivers like: - Rockchip RK3288 PM Domain (https://lkml.org/lkml/2014/11/6/30) - IMX.6 PU power domain (http://www.spinics.net/lists/arm-kernel/msg360709.html) to maintain list of clocks for GPD itself and these clocks should not be enabled by default, because they are used to power on/off Power domain in a specific way: - enable all clocks assigned to PD - power on/off PD - disable all clocks assigned to PD. After this patch it will be impossible to reuse Generic clock manipulation PM callbacks in cases described above. drivers/base/power/clock_ops.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c index b32b5d4..36cdff7 100644 --- a/drivers/base/power/clock_ops.c +++ b/drivers/base/power/clock_ops.c @@ -69,6 +69,10 @@ static void pm_clk_acquire(struct device *dev, struct pm_clock_entry *ce) ce->status = PCE_STATUS_ACQUIRED; dev_dbg(dev, "Clock %s managed by runtime PM.\n", ce->con_id); } + + if (!IS_ENABLED(CONFIG_PM_RUNTIME)) { + __pm_clk_enable(dev, ce); + } } static int __pm_clk_add(struct device *dev, const char *con_id,