diff mbox

kernel: power: snapshot: Remove unused function

Message ID 1421015258-24472-1-git-send-email-rickard_strandqvist@spectrumdigital.se (mailing list archive)
State Accepted, archived
Delegated to: Rafael Wysocki
Headers show

Commit Message

Rickard Strandqvist Jan. 11, 2015, 10:27 p.m. UTC
Remove the function get_safe_write_buffer() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 kernel/power/snapshot.c |    2 --
 1 file changed, 2 deletions(-)

Comments

Pavel Machek Jan. 12, 2015, 8:09 a.m. UTC | #1
On Sun 2015-01-11 23:27:38, Rickard Strandqvist wrote:
> Remove the function get_safe_write_buffer() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Acked-by: Pavel Machek <pavel@ucw.cz>

Rafael should take this, I guess...
Rafael J. Wysocki Jan. 30, 2015, 12:19 a.m. UTC | #2
On Monday, January 12, 2015 09:09:10 AM Pavel Machek wrote:
> On Sun 2015-01-11 23:27:38, Rickard Strandqvist wrote:
> > Remove the function get_safe_write_buffer() that is not used anywhere.
> > 
> > This was partially found by using a static code analysis program called cppcheck.
> > 
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>
> 
> Rafael should take this, I guess...

Queued up for 3.20, thanks!
diff mbox

Patch

diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index 791a618..dac8919 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -2309,8 +2309,6 @@  static inline void free_highmem_data(void)
 		free_image_page(buffer, PG_UNSAFE_CLEAR);
 }
 #else
-static inline int get_safe_write_buffer(void) { return 0; }
-
 static unsigned int
 count_highmem_image_pages(struct memory_bitmap *bm) { return 0; }