diff mbox

thermal: Kconfig: Remove config for not used EXYNOS_THERMAL_CORE

Message ID 1422357239-20316-1-git-send-email-l.majewski@samsung.com (mailing list archive)
State Accepted
Headers show

Commit Message

Lukasz Majewski Jan. 27, 2015, 11:13 a.m. UTC
After removing exynos_thermal_common.[c|h] files the CONFIG_EXYNOS_THERMA_CORE
is not needed anymore.
This patch removes this entry from Kconfig.

Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
 drivers/thermal/samsung/Kconfig | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Eduardo Valentin Jan. 27, 2015, 2:55 p.m. UTC | #1
On Tue, Jan 27, 2015 at 12:13:59PM +0100, Lukasz Majewski wrote:
> After removing exynos_thermal_common.[c|h] files the CONFIG_EXYNOS_THERMA_CORE
> is not needed anymore.
> This patch removes this entry from Kconfig.
> 
> Reported-by: Paul Bolle <pebolle@tiscali.nl>
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>

This patch looks fine to me and I am about to queue it in my fixes tree.
However, you must carry along another patch to remove this entry:
arch/arm/configs/exynos_defconfig:CONFIG_EXYNOS_THERMAL_CORE=y

Can you please post it and ask Kim to queue the above suggested removal
too?

> ---
>  drivers/thermal/samsung/Kconfig | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index c43306e..c8e35c1 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -7,12 +7,3 @@ config EXYNOS_THERMAL
>  	  the TMU, reports temperature and handles cooling action if defined.
>  	  This driver uses the Exynos core thermal APIs and TMU configuration
>  	  data from the supported SoCs.
> -
> -config EXYNOS_THERMAL_CORE
> -	bool "Core thermal framework support for EXYNOS SOCs"
> -	depends on EXYNOS_THERMAL
> -	help
> -	  If you say yes here you get support for EXYNOS TMU
> -	  (Thermal Management Unit) common registration/unregistration
> -	  functions to the core thermal layer and also to use the generic
> -	  CPU cooling APIs.
> -- 
> 2.0.0.rc2
>
Lukasz Majewski Jan. 27, 2015, 3 p.m. UTC | #2
Hi Eduardo,

> On Tue, Jan 27, 2015 at 12:13:59PM +0100, Lukasz Majewski wrote:
> > After removing exynos_thermal_common.[c|h] files the
> > CONFIG_EXYNOS_THERMA_CORE is not needed anymore.
> > This patch removes this entry from Kconfig.
> > 
> > Reported-by: Paul Bolle <pebolle@tiscali.nl>
> > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> This patch looks fine to me and I am about to queue it in my fixes
> tree. However, you must carry along another patch to remove this
> entry: arch/arm/configs/exynos_defconfig:CONFIG_EXYNOS_THERMAL_CORE=y

OK.

> 
> Can you please post it and ask Kim to queue the above suggested
> removal too?

OK.

> 
> > ---
> >  drivers/thermal/samsung/Kconfig | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> > diff --git a/drivers/thermal/samsung/Kconfig
> > b/drivers/thermal/samsung/Kconfig index c43306e..c8e35c1 100644
> > --- a/drivers/thermal/samsung/Kconfig
> > +++ b/drivers/thermal/samsung/Kconfig
> > @@ -7,12 +7,3 @@ config EXYNOS_THERMAL
> >  	  the TMU, reports temperature and handles cooling action
> > if defined. This driver uses the Exynos core thermal APIs and TMU
> > configuration data from the supported SoCs.
> > -
> > -config EXYNOS_THERMAL_CORE
> > -	bool "Core thermal framework support for EXYNOS SOCs"
> > -	depends on EXYNOS_THERMAL
> > -	help
> > -	  If you say yes here you get support for EXYNOS TMU
> > -	  (Thermal Management Unit) common
> > registration/unregistration
> > -	  functions to the core thermal layer and also to use the
> > generic
> > -	  CPU cooling APIs.
> > -- 
> > 2.0.0.rc2
> >
diff mbox

Patch

diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
index c43306e..c8e35c1 100644
--- a/drivers/thermal/samsung/Kconfig
+++ b/drivers/thermal/samsung/Kconfig
@@ -7,12 +7,3 @@  config EXYNOS_THERMAL
 	  the TMU, reports temperature and handles cooling action if defined.
 	  This driver uses the Exynos core thermal APIs and TMU configuration
 	  data from the supported SoCs.
-
-config EXYNOS_THERMAL_CORE
-	bool "Core thermal framework support for EXYNOS SOCs"
-	depends on EXYNOS_THERMAL
-	help
-	  If you say yes here you get support for EXYNOS TMU
-	  (Thermal Management Unit) common registration/unregistration
-	  functions to the core thermal layer and also to use the generic
-	  CPU cooling APIs.