From patchwork Tue Feb 10 18:21:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Punit Agrawal X-Patchwork-Id: 5808471 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1506ABF440 for ; Tue, 10 Feb 2015 18:21:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 26CF020120 for ; Tue, 10 Feb 2015 18:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2681220115 for ; Tue, 10 Feb 2015 18:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822AbbBJSVX (ORCPT ); Tue, 10 Feb 2015 13:21:23 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:44858 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752198AbbBJSVX (ORCPT ); Tue, 10 Feb 2015 13:21:23 -0500 Received: from e105922-lin.cambridge.arm.com (e105922-lin.cambridge.arm.com [10.2.131.69]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with SMTP id t1AILF2c008410; Tue, 10 Feb 2015 18:21:15 GMT Received: by e105922-lin.cambridge.arm.com (sSMTP sendmail emulation); Tue, 10 Feb 2015 18:21:48 +0000 From: Punit Agrawal To: edubezval@gmail.com Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org, Punit Agrawal Subject: [PATCH] thermal: Default OF created trip points to writable Date: Tue, 10 Feb 2015 18:21:46 +0000 Message-Id: <1423592506-20620-1-git-send-email-punit.agrawal@arm.com> X-Mailer: git-send-email 2.1.4 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When registering a thermal zone from device tree, default the trip points to writable. By default, only the root user can change these. This allows the trip points to be tweaked after the system has booted. Signed-off-by: Punit Agrawal --- Hi Eduardo, We've been using this patch internally and haven't run into any issues. Without these changes there is no way to change trip points from a running system. Comments welcome. Cheers, Punit drivers/thermal/of-thermal.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c index 668fb1b..b7ad5c0 100644 --- a/drivers/thermal/of-thermal.c +++ b/drivers/thermal/of-thermal.c @@ -865,6 +865,7 @@ int __init of_parse_thermal_zones(void) for_each_child_of_node(np, child) { struct thermal_zone_device *zone; struct thermal_zone_params *tzp; + int i, mask = 0; /* Check whether child is enabled or not */ if (!of_device_is_available(child)) @@ -891,8 +892,11 @@ int __init of_parse_thermal_zones(void) /* No hwmon because there might be hwmon drivers registering */ tzp->no_hwmon = true; + for (i = 0; i < tz->ntrips; i++) + mask |= 1 << i; + zone = thermal_zone_device_register(child->name, tz->ntrips, - 0, tz, + mask, tz, ops, tzp, tz->passive_delay, tz->polling_delay);