From patchwork Wed Feb 18 10:07:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Majewski X-Patchwork-Id: 5843251 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CEC059F30C for ; Wed, 18 Feb 2015 10:11:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0B1902024C for ; Wed, 18 Feb 2015 10:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0D93C20211 for ; Wed, 18 Feb 2015 10:11:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751245AbbBRKLf (ORCPT ); Wed, 18 Feb 2015 05:11:35 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:60314 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750742AbbBRKLd (ORCPT ); Wed, 18 Feb 2015 05:11:33 -0500 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NJY001PZPN7RL80@mailout1.samsung.com>; Wed, 18 Feb 2015 19:11:32 +0900 (KST) X-AuditID: cbfee61a-f79c06d000004e71-f4-54e46553ac6b Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 8F.33.20081.35564E45; Wed, 18 Feb 2015 19:11:31 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NJY00IQ4PGTKC50@mmp1.samsung.com>; Wed, 18 Feb 2015 19:11:31 +0900 (KST) From: Lukasz Majewski To: Eduardo Valentin , Kamil Debski , Jean Delvare , Guenter Roeck , Kukjin Kim Cc: lm-sensors@lm-sensors.org, Linux PM list , "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, Lukasz Majewski , Kukjin Kim , linux-kernel@vger.kernel.org, Sjoerd Simons , Abhilash Kesavan , Abhilash Kesavan , Lukasz Majewski Subject: [PATCH v4 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Date: Wed, 18 Feb 2015 11:07:34 +0100 Message-id: <1424254056-5904-7-git-send-email-l.majewski@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-reply-to: <1424254056-5904-1-git-send-email-l.majewski@samsung.com> References: <1418897591-18332-1-git-send-email-l.majewski@samsung.com> <1424254056-5904-1-git-send-email-l.majewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsVy+t9jAd3g1CchBmsnGVo8XrOYyWL+kXOs FvOvXGO1WHr3E5vFj9cX2CzW/FWy6F1wlc2i//FrZos3j7gt3jzczGhxedccNovPvUcYLWac 38dk8WThGSaLO9P2sllMP/6W1UHA4+/z6yweO2fdZffYtKqTzePBxN1sHuumvWX22Pm9gd2j b8sqRo/Np6s9Pm+SC+CM4rJJSc3JLEst0rdL4Mo49/c/a8F1gYrtH/4yNzCu4O1i5OSQEDCR OH/iESOELSZx4d56ti5GLg4hgUWMEveXnIVyupgkJp77ywxSxSagJ/H57lMmkISIwHZGiRXz voFVMQtcY5bYt/koE0iVsECKxNyL28BsFgFVia+HF4PZvAKuEh/bX0LtU5TofjaBDcTmFHCT 2LpnGTvEuiZGiXlLfzJPYORdwMiwilE0tSC5oDgpPddQrzgxt7g0L10vOT93EyM4sJ9J7WBc 2WBxiFGAg1GJh7fh9+MQIdbEsuLK3EOMEhzMSiK88fFPQoR4UxIrq1KL8uOLSnNSiw8xSnOw KInzKtm3hQgJpCeWpGanphakFsFkmTg4pRoYtb5bZN64l+ygs0BQt4ev8Nd5nvpn78JZzzrd Op5csSCw06J07VHe/aaRD6cpt2oyV0j8LIprNPsSJJVQX3Z4kXVo78z4uIQr8zjOfM6wMT/4 oEC3v1dpQ/mXncc896x/faeJcwl/l4DuV/VfXdIq29wvSD1omJS3vtHtTvTROKU1+9tlzn9S YinOSDTUYi4qTgQAYLO8LWgCAAA= Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski --- Changes for v2: - None Changes for v3: - The commit headline has been reedited. Changes for v4: - Protect "if (ctx->pwm_value == pwm)" with ctx lock - Initialize ret with zero --- drivers/hwmon/pwm-fan.c | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index 1991d903..bd42d39 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -33,20 +33,14 @@ struct pwm_fan_ctx { unsigned char pwm_value; }; -static ssize_t set_pwm(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) +static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm) { - struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); - unsigned long pwm, duty; - ssize_t ret; - - if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM) - return -EINVAL; + unsigned long duty; + int ret = 0; mutex_lock(&ctx->lock); - if (ctx->pwm_value == pwm) - goto exit_set_pwm_no_change; + goto exit_set_pwm_err; if (pwm == 0) { pwm_disable(ctx->pwm); @@ -66,13 +60,28 @@ static ssize_t set_pwm(struct device *dev, struct device_attribute *attr, exit_set_pwm: ctx->pwm_value = pwm; -exit_set_pwm_no_change: - ret = count; exit_set_pwm_err: mutex_unlock(&ctx->lock); return ret; } +static ssize_t set_pwm(struct device *dev, struct device_attribute *attr, + const char *buf, size_t count) +{ + struct pwm_fan_ctx *ctx = dev_get_drvdata(dev); + unsigned long pwm; + int ret; + + if (kstrtoul(buf, 10, &pwm) || pwm > MAX_PWM) + return -EINVAL; + + ret = __set_pwm(ctx, pwm); + if (ret) + return ret; + + return count; +} + static ssize_t show_pwm(struct device *dev, struct device_attribute *attr, char *buf) {