diff mbox

[1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build

Message ID 1426541230-928-1-git-send-email-richard@nod.at (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Richard Weinberger March 16, 2015, 9:27 p.m. UTC
Fixes:
drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_map_memory’:
drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
  cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
  ^
drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
  cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
               ^
drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_setup’:
drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
  iounmap(cmt->mapbase);

Signed-off-by: Richard Weinberger <richard@nod.at>
---
 drivers/clocksource/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven March 17, 2015, 8:18 a.m. UTC | #1
On Mon, Mar 16, 2015 at 10:27 PM, Richard Weinberger <richard@nod.at> wrote:
> Fixes:
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_map_memory’:
> drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>   cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>   ^
> drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>   cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>                ^
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_setup’:
> drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>   iounmap(cmt->mapbase);
>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Daniel Lezcano March 20, 2015, 2:05 p.m. UTC | #2
On 03/16/2015 10:27 PM, Richard Weinberger wrote:
> Fixes:
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_map_memory’:
> drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>    cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>    ^
> drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>    cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>                 ^
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_setup’:
> drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>    iounmap(cmt->mapbase);
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---

Applied to my tree for v4.0 fix.

Thanks !


>   drivers/clocksource/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 68161f7..c948f4e 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -192,6 +192,7 @@ config SYS_SUPPORTS_EM_STI
>   config SH_TIMER_CMT
>   	bool "Renesas CMT timer driver" if COMPILE_TEST
>   	depends on GENERIC_CLOCKEVENTS
> +	depends on HAS_IOMEM
>   	default SYS_SUPPORTS_SH_CMT
>   	help
>   	  This enables build of a clocksource and clockevent driver for
>
diff mbox

Patch

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 68161f7..c948f4e 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -192,6 +192,7 @@  config SYS_SUPPORTS_EM_STI
 config SH_TIMER_CMT
 	bool "Renesas CMT timer driver" if COMPILE_TEST
 	depends on GENERIC_CLOCKEVENTS
+	depends on HAS_IOMEM
 	default SYS_SUPPORTS_SH_CMT
 	help
 	  This enables build of a clocksource and clockevent driver for