| Message ID | 1427385240-6086-4-git-send-email-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Eduardo Valentin |
| Headers | show |
On Thu, Mar 26, 2015 at 04:53:50PM +0100, Sascha Hauer wrote: > When the thermal zone has no get_temp callback then thermal_zone_device_register() > calls thermal_zone_device_set_polling() with a polling delay of 0. This > only cancels the poll_queue. Since the poll_queue hasn't been scheduled this > is a no-op. Remove it. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> This seams reasonable to me: Acked-by: Eduardo Valentin <edubezval@gmail.com> > --- > drivers/thermal/thermal_core.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c > index c735ac4c..dcea909 100644 > --- a/drivers/thermal/thermal_core.c > +++ b/drivers/thermal/thermal_core.c > @@ -1571,9 +1571,6 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, > > INIT_DELAYED_WORK(&(tz->poll_queue), thermal_zone_device_check); > > - if (!tz->ops->get_temp) > - thermal_zone_device_set_polling(tz, 0); > - > thermal_zone_device_update(tz); > > return tz; > -- > 2.1.4 >
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c index c735ac4c..dcea909 100644 --- a/drivers/thermal/thermal_core.c +++ b/drivers/thermal/thermal_core.c @@ -1571,9 +1571,6 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, INIT_DELAYED_WORK(&(tz->poll_queue), thermal_zone_device_check); - if (!tz->ops->get_temp) - thermal_zone_device_set_polling(tz, 0); - thermal_zone_device_update(tz); return tz;
When the thermal zone has no get_temp callback then thermal_zone_device_register() calls thermal_zone_device_set_polling() with a polling delay of 0. This only cancels the poll_queue. Since the poll_queue hasn't been scheduled this is a no-op. Remove it. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/thermal/thermal_core.c | 3 --- 1 file changed, 3 deletions(-)