| Message ID | 1437056730-15247-3-git-send-email-jlee@suse.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > Add get variable and set variable function to EFI services pointer > table for supporting later functions of hibernate signature > verification to keep the HMAC key in efi boot service veriable. > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> Maybe mention that we want to be able to read/write variables from within the EFI boot stub? That's really why you want to add {get,set}_variable pointers. s/veriable/variable/ Rest of the patch looks good. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 30, 2015 at 04:19:58PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > Add get variable and set variable function to EFI services pointer > > table for supporting later functions of hibernate signature > > verification to keep the HMAC key in efi boot service veriable. > > > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> > > Maybe mention that we want to be able to read/write variables from > within the EFI boot stub? That's really why you want to add > {get,set}_variable pointers. > I will add more detail for accessing efi boot service variable is because that will not touched by unauthenticated codes. > s/veriable/variable/ > I will fix the typo. > Rest of the patch looks good. > Thanks a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/x86/boot/compressed/eboot.c b/arch/x86/boot/compressed/eboot.c index 2c82bd1..0ffb6db 100644 --- a/arch/x86/boot/compressed/eboot.c +++ b/arch/x86/boot/compressed/eboot.c @@ -30,12 +30,14 @@ static void setup_boot_services##bits(struct efi_config *c) \ { \ efi_system_table_##bits##_t *table; \ efi_boot_services_##bits##_t *bt; \ + efi_runtime_services_##bits##_t *rt; \ \ table = (typeof(table))sys_table; \ \ c->text_output = table->con_out; \ \ bt = (typeof(bt))(unsigned long)(table->boottime); \ + rt = (typeof(rt))(unsigned long)(table->runtime); \ \ c->allocate_pool = bt->allocate_pool; \ c->allocate_pages = bt->allocate_pages; \ @@ -45,6 +47,8 @@ static void setup_boot_services##bits(struct efi_config *c) \ c->locate_handle = bt->locate_handle; \ c->handle_protocol = bt->handle_protocol; \ c->exit_boot_services = bt->exit_boot_services; \ + c->get_variable = rt->get_variable; \ + c->set_variable = rt->set_variable; \ } BOOT_SERVICES(32); BOOT_SERVICES(64); diff --git a/arch/x86/boot/compressed/head_32.S b/arch/x86/boot/compressed/head_32.S index 8ef964d..a7db5e3 100644 --- a/arch/x86/boot/compressed/head_32.S +++ b/arch/x86/boot/compressed/head_32.S @@ -54,7 +54,7 @@ ENTRY(efi_pe_entry) /* Relocate efi_config->call() */ leal efi32_config(%esi), %eax - add %esi, 88(%eax) + add %esi, 104(%eax) pushl %eax call make_boot_params @@ -80,7 +80,7 @@ ENTRY(efi32_stub_entry) /* Relocate efi_config->call() */ leal efi32_config(%esi), %eax - add %esi, 88(%eax) + add %esi, 104(%eax) pushl %eax 2: call efi_main @@ -230,7 +230,7 @@ relocated: #ifdef CONFIG_EFI_STUB .data efi32_config: - .fill 11,8,0 + .fill 13,8,0 .long efi_call_phys .long 0 .byte 0 diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S index b0c0d16..471b1c1 100644 --- a/arch/x86/boot/compressed/head_64.S +++ b/arch/x86/boot/compressed/head_64.S @@ -255,7 +255,7 @@ ENTRY(efi_pe_entry) /* * Relocate efi_config->call(). */ - addq %rbp, efi64_config+88(%rip) + addq %rbp, efi64_config+104(%rip) movq %rax, %rdi call make_boot_params @@ -275,7 +275,7 @@ handover_entry: * Relocate efi_config->call(). */ movq efi_config(%rip), %rax - addq %rbp, 88(%rax) + addq %rbp, 104(%rax) 2: movq efi_config(%rip), %rdi call efi_main @@ -448,14 +448,14 @@ efi_config: #ifdef CONFIG_EFI_MIXED .global efi32_config efi32_config: - .fill 11,8,0 + .fill 13,8,0 .quad efi64_thunk .byte 0 #endif .global efi64_config efi64_config: - .fill 11,8,0 + .fill 13,8,0 .quad efi_call .byte 1 #endif /* CONFIG_EFI_STUB */ diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h index 155162e..a274aa8 100644 --- a/arch/x86/include/asm/efi.h +++ b/arch/x86/include/asm/efi.h @@ -175,6 +175,8 @@ struct efi_config { u64 handle_protocol; u64 exit_boot_services; u64 text_output; + u64 get_variable; + u64 set_variable; efi_status_t (*call)(unsigned long, ...); bool is64; } __packed;
Add get variable and set variable function to EFI services pointer table for supporting later functions of hibernate signature verification to keep the HMAC key in efi boot service veriable. Signed-off-by: Lee, Chun-Yi <jlee@suse.com> --- arch/x86/boot/compressed/eboot.c | 4 ++++ arch/x86/boot/compressed/head_32.S | 6 +++--- arch/x86/boot/compressed/head_64.S | 8 ++++---- arch/x86/include/asm/efi.h | 2 ++ 4 files changed, 13 insertions(+), 7 deletions(-)