| Message ID | 1437056730-15247-8-git-send-email-jlee@suse.com (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > Moved the function of transferring EFI status to kernel error for > later used by EFI stub. > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> > --- > drivers/firmware/efi/vars.c | 33 --------------------------------- > include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++ > 2 files changed, 33 insertions(+), 33 deletions(-) The patch contents are fine but the title could do with some work, "public" isn't a verb. I think "Make efi_status_to_err() public" would be fine. -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 30, 2015 at 05:23:22PM +0100, Matt Fleming wrote: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > Moved the function of transferring EFI status to kernel error for > > later used by EFI stub. > > > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> > > --- > > drivers/firmware/efi/vars.c | 33 --------------------------------- > > include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+), 33 deletions(-) > > The patch contents are fine but the title could do with some work, > "public" isn't a verb. I think "Make efi_status_to_err() public" would > be fine. > Thanks for your correcting, I will change the patch title. Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 30 Jul 2015 17:23:22 +0100, Matt Fleming said: > On Thu, 2015-07-16 at 22:25 +0800, Lee, Chun-Yi wrote: > > Moved the function of transferring EFI status to kernel error for > > later used by EFI stub. > > > > Signed-off-by: Lee, Chun-Yi <jlee@suse.com> > > --- > > drivers/firmware/efi/vars.c | 33 --------------------------------- > > include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++ > > 2 files changed, 33 insertions(+), 33 deletions(-) > > The patch contents are fine but the title could do with some work, > "public" isn't a verb. In English, any noun can be verbed. :) -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/firmware/efi/vars.c b/drivers/firmware/efi/vars.c index 70a0fb1..f5ede94 100644 --- a/drivers/firmware/efi/vars.c +++ b/drivers/firmware/efi/vars.c @@ -237,39 +237,6 @@ check_var_size(u32 attributes, unsigned long size) return fops->query_variable_store(attributes, size); } -static int efi_status_to_err(efi_status_t status) -{ - int err; - - switch (status) { - case EFI_SUCCESS: - err = 0; - break; - case EFI_INVALID_PARAMETER: - err = -EINVAL; - break; - case EFI_OUT_OF_RESOURCES: - err = -ENOSPC; - break; - case EFI_DEVICE_ERROR: - err = -EIO; - break; - case EFI_WRITE_PROTECTED: - err = -EROFS; - break; - case EFI_SECURITY_VIOLATION: - err = -EACCES; - break; - case EFI_NOT_FOUND: - err = -ENOENT; - break; - default: - err = -EINVAL; - } - - return err; -} - static bool variable_is_present(efi_char16_t *variable_name, efi_guid_t *vendor, struct list_head *head) { diff --git a/include/linux/efi.h b/include/linux/efi.h index a628f83..9239f32 100644 --- a/include/linux/efi.h +++ b/include/linux/efi.h @@ -907,6 +907,39 @@ static inline char *efi_status_to_str(efi_status_t status) return str; } +static inline int efi_status_to_err(efi_status_t status) +{ + int err; + + switch (status) { + case EFI_SUCCESS: + err = 0; + break; + case EFI_INVALID_PARAMETER: + err = -EINVAL; + break; + case EFI_OUT_OF_RESOURCES: + err = -ENOSPC; + break; + case EFI_DEVICE_ERROR: + err = -EIO; + break; + case EFI_WRITE_PROTECTED: + err = -EROFS; + break; + case EFI_SECURITY_VIOLATION: + err = -EACCES; + break; + case EFI_NOT_FOUND: + err = -ENOENT; + break; + default: + err = -EINVAL; + } + + return err; +} + extern void efi_init (void); extern void *efi_get_pal_addr (void); extern void efi_map_pal_code (void);
Moved the function of transferring EFI status to kernel error for later used by EFI stub. Signed-off-by: Lee, Chun-Yi <jlee@suse.com> --- drivers/firmware/efi/vars.c | 33 --------------------------------- include/linux/efi.h | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 33 deletions(-)