From patchwork Tue Jan 12 17:17:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas Stach X-Patchwork-Id: 8019281 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 38DD29F716 for ; Tue, 12 Jan 2016 17:17:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B1B3203FB for ; Tue, 12 Jan 2016 17:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D35B203F3 for ; Tue, 12 Jan 2016 17:17:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933829AbcALRRZ (ORCPT ); Tue, 12 Jan 2016 12:17:25 -0500 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41227 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933677AbcALRRZ (ORCPT ); Tue, 12 Jan 2016 12:17:25 -0500 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7] helo=dude.pengutronix.de.) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1aJ2ZO-000434-Bx; Tue, 12 Jan 2016 18:17:22 +0100 From: Lucas Stach To: "Rafael J . Wysocki" , Thomas Gleixner Cc: Pavel Machek , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, patchwork-lst@pengutronix.de Subject: [PATCH 2/2] PM / Runtime: use deferrable timer for autosuspend Date: Tue, 12 Jan 2016 18:17:20 +0100 Message-Id: <1452619040-27137-2-git-send-email-l.stach@pengutronix.de> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1452619040-27137-1-git-send-email-l.stach@pengutronix.de> References: <1452619040-27137-1-git-send-email-l.stach@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The timeouts used in PM autosuspend are relatively coarse (the shortest I could find in a quick search through the kernel is 50ms). As they are already handled relaxed by saving the overhead of always rearming the timer by opportunistically suspending a device a bit early, it should not matter if the the timeout is missed slightly. By using a deferrable timer the CPU will not be woken just to handle the autosuspend timeout, but handling will be batched with other wakeups in the system. Signed-off-by: Lucas Stach Acked-by: Pavel Machek --- drivers/base/power/runtime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index e1a10a03df8e..975a282600ff 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -1383,7 +1383,7 @@ void pm_runtime_init(struct device *dev) INIT_WORK(&dev->power.work, pm_runtime_work); dev->power.timer_expires = 0; - setup_timer(&dev->power.suspend_timer, pm_suspend_timer_fn, + setup_deferrable_timer(&dev->power.suspend_timer, pm_suspend_timer_fn, (unsigned long)dev); init_waitqueue_head(&dev->power.wait_queue);