From patchwork Mon Feb 15 07:33:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 8310711 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E2194C02AA for ; Mon, 15 Feb 2016 07:37:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 13D9D204EB for ; Mon, 15 Feb 2016 07:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FD09204AD for ; Mon, 15 Feb 2016 07:37:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752331AbcBOHef (ORCPT ); Mon, 15 Feb 2016 02:34:35 -0500 Received: from mail-pa0-f68.google.com ([209.85.220.68]:33877 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbcBOHec (ORCPT ); Mon, 15 Feb 2016 02:34:32 -0500 Received: by mail-pa0-f68.google.com with SMTP id yy13so6865332pab.1; Sun, 14 Feb 2016 23:34:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=lWZE6SFUy0nu1lwZcEWg2z2VgQQ/ad01N7TCtRv3UT4=; b=QskrWz2U1/vstDM/c7Z+MNhdxQ1e5cDxflVJMZK6ZD69t9brYEkhFBgJWPfsCZQOmP iPM68lax2pttrkx2IY5XtV+wjwiI2NM1uvg0EBVgDDhziJr4sOIpc7VMW/SRqxav+yyF F4KQIk1W61j4GMGCD1fAlgN0mE+LEAGVpz/36dxxkKw3US1pbofUN5p/m10Pwl9W2W0f YaxXxT4fE5sWIUDEY3Q85BxultIFs3hRRlZsPhseh0qgkpmvww0Jwk7Fw/FbhaXSGSG2 IGph+HvnFpR2jIME+dHsP0sao5uDneYrjqhcVe2kiRxxYg1u0DMkDHSd3onI9YZRAhOt FNFQ== X-Gm-Message-State: AG10YORLJfh6t3HQfd2nis5SUJYfVQm7yjx6oyz5GWm+GyRglBLORrtqP7kPUeO8G1+qKw== X-Received: by 10.66.246.165 with SMTP id xx5mr21539033pac.87.1455521672437; Sun, 14 Feb 2016 23:34:32 -0800 (PST) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id o17sm36040286pfj.50.2016.02.14.23.34.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 14 Feb 2016 23:34:31 -0800 (PST) From: Caesar Wang To: Heiko Stuebner , edubezval@gmail.com Cc: huangtao@rock-chips.com, Michael Turquette , linux-pm@vger.kernel.org, Stephen Boyd , zhangqing@rock-chips.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Dmitry Torokhov , Jeffy Chen , Zhang Rui , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Caesar Wang Subject: [RESEND PATCH 3/8] thermal: rockchip: fix a impossible condition caused by the warning Date: Mon, 15 Feb 2016 15:33:28 +0800 Message-Id: <1455521613-27340-4-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1455521613-27340-1-git-send-email-wxt@rock-chips.com> References: <1455521613-27340-1-git-send-email-wxt@rock-chips.com> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As the Dan report the smatch check the thermal driver warning: drivers/thermal/rockchip_thermal.c:551 rockchip_configure_from_dt() warn: impossible condition '(thermal->tshut_temp > ((~0 >> 1))) => (s32min-s32max > s32max)' Although The shut_temp read from DT is u32,the temperature is currently represented as int not long in the thermal driver. Let's change to make shut_temp instead of the thermal->tshut_temp for the condition. Fixes: commit 437df2172e8d ("thermal: rockchip: consistently use int for temperatures") Reported-by: Dan Carpenter Signed-off-by: Caesar Wang --- drivers/thermal/rockchip_thermal.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index b58e3fb..433085a 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -693,15 +693,14 @@ static int rockchip_configure_from_dt(struct device *dev, thermal->chip->tshut_temp); thermal->tshut_temp = thermal->chip->tshut_temp; } else { + if (shut_temp > INT_MAX) { + dev_err(dev, "Invalid tshut temperature specified: %d\n", + shut_temp); + return -ERANGE; + } thermal->tshut_temp = shut_temp; } - if (thermal->tshut_temp > INT_MAX) { - dev_err(dev, "Invalid tshut temperature specified: %d\n", - thermal->tshut_temp); - return -ERANGE; - } - if (of_property_read_u32(np, "rockchip,hw-tshut-mode", &tshut_mode)) { dev_warn(dev, "Missing tshut mode property, using default (%s)\n",