From patchwork Tue Feb 23 01:22:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Muckle X-Patchwork-Id: 8385811 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8124CC0554 for ; Tue, 23 Feb 2016 01:24:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9966D2045B for ; Tue, 23 Feb 2016 01:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5D2EC204D1 for ; Tue, 23 Feb 2016 01:24:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932393AbcBWBXL (ORCPT ); Mon, 22 Feb 2016 20:23:11 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36204 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932316AbcBWBXE (ORCPT ); Mon, 22 Feb 2016 20:23:04 -0500 Received: by mail-pa0-f54.google.com with SMTP id yy13so100322878pab.3 for ; Mon, 22 Feb 2016 17:23:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eaaRgZCiVdVHrAO4+5m+iQbzM73gQg7n5LzR2+pmlto=; b=cqTClh58M0m+uTEFIorlyD4BqWUPJbVMmRWTXjjlo/pmtA5JmcVJPzjscSjXY+88l+ XNZ0YvdiK0XNHWCLGj2CmlLiKF+eLkhLgcctGksnNN6sLuuEiION9Qi1YO9/MXfDqKJp 0Ff1X1+BoahvCYhnAsGy3Ir37rv3XECHqtse0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eaaRgZCiVdVHrAO4+5m+iQbzM73gQg7n5LzR2+pmlto=; b=msUl4fK80Ihk9D8hAlqr1qGyRkzjAQFXzOEMU9QT7k0AOHQb6bP32iFHY1HPsArOWq QqOpJ/IFloFnC/McuLXh4Y2or/am4/zhJg86XVWVScUYxO6QIweATz26e48Rn1Xtq3Jl MNO2Be36yBd023ahm/zgw4PCfQrw7qJli0rS5eQCsiBu6ioYgTXM9/tDDtgQg8/Tl10t rjLbynoPoUImGOWW3lz66RJJCURzZdcQ7XwzC1lHcPDAz9JYkNxpq44ZDfdvIslRBEp8 QXPHCuWbJfUuY41xaRVlOxaEl1q9rFzYBwEDPBCkf14/a6y1RLZQKUuuv1i2hu6QypcU A4Hg== X-Gm-Message-State: AG10YOTEQAxGJBpUdEaXDxdRrHSaT9HolOWJYnZaKvcPaQbXyv3WYuNIrTpgXTnlgEY5bHwJ X-Received: by 10.66.233.131 with SMTP id tw3mr43116914pac.89.1456190584142; Mon, 22 Feb 2016 17:23:04 -0800 (PST) Received: from graphite.smuckle.net (cpe-75-80-155-7.san.res.rr.com. [75.80.155.7]) by smtp.gmail.com with ESMTPSA id t29sm39626789pfi.8.2016.02.22.17.23.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 22 Feb 2016 17:23:03 -0800 (PST) From: Steve Muckle X-Google-Original-From: Steve Muckle To: Peter Zijlstra , Ingo Molnar , "Rafael J. Wysocki" Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Juri Lelli , Patrick Bellasi , Michael Turquette Subject: [RFCv7 PATCH 08/10] sched: remove call of sched_avg_update from sched_rt_avg_update Date: Mon, 22 Feb 2016 17:22:48 -0800 Message-Id: <1456190570-4475-9-git-send-email-smuckle@linaro.org> X-Mailer: git-send-email 2.4.10 In-Reply-To: <1456190570-4475-1-git-send-email-smuckle@linaro.org> References: <1456190570-4475-1-git-send-email-smuckle@linaro.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Vincent Guittot rt_avg is only used to scale the available CPU's capacity for CFS tasks. As the update of this scaling is done during periodic load balance, we only have to ensure that sched_avg_update has been called before any periodic load balancing. This requirement is already fulfilled by __update_cpu_load so the call in sched_rt_avg_update, which is part of the hotpath, is useless. Signed-off-by: Vincent Guittot Signed-off-by: Steve Muckle --- kernel/sched/sched.h | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 59747d8..3df21f2 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1498,7 +1498,6 @@ static inline void set_dl_cpu_capacity(int cpu, bool request, static inline void sched_rt_avg_update(struct rq *rq, u64 rt_delta) { rq->rt_avg += rt_delta * arch_scale_freq_capacity(NULL, cpu_of(rq)); - sched_avg_update(rq); } #else static inline void sched_rt_avg_update(struct rq *rq, u64 rt_delta) { }